Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libical: 3.0.19 -> 3.0.20 #392708

Merged
merged 2 commits into from
Mar 25, 2025
Merged

libical: 3.0.19 -> 3.0.20 #392708

merged 2 commits into from
Mar 25, 2025

Conversation

matthiasbeyer
Copy link
Contributor

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@matthiasbeyer
libical: 3.0.19 -> 3.0.20
1aa66fb 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer matthiasbeyer requested a review from K900 March 24, 2025 12:40
@matthiasbeyer matthiasbeyer mentioned this pull request Mar 24, 2025
Draft
13 tasks
K900
K900 reviewed Mar 25, 2025
View reviewed changes
Copy link
Contributor

@K900 K900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libical changes LGTM, also thanks for reminding me why I hate cmake

@matthiasbeyer
libical: Transform to use finalAttrs
8c3a357 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer matthiasbeyer force-pushed the staging-next-update-libical branch from 5fb0850 to 8c3a357 Compare March 25, 2025 08:23
@matthiasbeyer matthiasbeyer requested review from toastal and K900 March 25, 2025 08:25
@K900
Copy link
Contributor

K900 commented Mar 25, 2025

Should now go to staging, as there's no active staging-next

@matthiasbeyer
Copy link
Contributor Author

Feel free to rebase this.

@K900 K900 changed the base branch from staging-next to staging March 25, 2025 09:01
@K900 K900 merged commit ec69aa3 into NixOS:staging Mar 25, 2025
29 of 34 checks passed
@matthiasbeyer matthiasbeyer deleted the staging-next-update-libical branch March 25, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toastal toastal

@K900 K900

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthiasbeyer @K900 @toastal