[Backport release-24.11] electron-{bin,source,chromedriver}_35: init at 35.0.3 #392749
+1,034
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![nixpkgs-ci[bot]](https://avatars.githubusercontent.com/u/487568?s=60&v=4){kind=small}
- Changelog: https://github.com/electron/electron/releases/tag/v35.0.0 - Changelog: https://github.com/electron/electron/releases/tag/v35.0.1 - Changelog: https://github.com/electron/electron/releases/tag/v35.0.2 - Changelog: https://github.com/electron/electron/releases/tag/v35.0.3 (cherry picked from commit cd050a1)
- Changelog: https://github.com/electron/electron/releases/tag/v35.0.0 - Changelog: https://github.com/electron/electron/releases/tag/v35.0.1 - Changelog: https://github.com/electron/electron/releases/tag/v35.0.2 - Changelog: https://github.com/electron/electron/releases/tag/v35.0.3 (cherry picked from commit c912334)
- Changelog: https://github.com/electron/electron/releases/tag/v35.0.0 - Changelog: https://github.com/electron/electron/releases/tag/v35.0.1 - Changelog: https://github.com/electron/electron/releases/tag/v35.0.2 - Changelog: https://github.com/electron/electron/releases/tag/v35.0.3 (cherry picked from commit 9c12ed5)
electron/electron#44657 https://github.com/electron/electron/blob/e4bd0cd3dcc57cb6889f845c75952bf999cbf581/script/node/generate_node_headers.py#L34-L39 Co-authored-by: TomaSajt <62384384+TomaSajt@users.noreply.github.com> Co-authored-by: Emily <git@emilylange.de> (cherry picked from commit 112942f)
because electron 35+ needs gn in PATH at build time
[41984/43140] ACTION //third_party/electron_node:generate_config_gypi(//build/toolchain/linux/unbundle:default)
FAILED: gen/third_party/electron_node/config.gypi
python3 ../../third_party/electron_node/tools/generate_config_gypi.py gen/third_party/electron_node/config.gypi --out-dir . --dep-file gen/third_party/electron_node/generate_config_gypi.d --node-gn-path //third_party/electron_node
Traceback (most recent call last):
File "/build/src/out/Release/../../third_party/electron_node/tools/generate_config_gypi.py", line 113, in <module>
main()
File "/build/src/out/Release/../../third_party/electron_node/tools/generate_config_gypi.py", line 100, in main
config = get_gn_config(args.out_dir)
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/build/src/out/Release/../../third_party/electron_node/tools/generate_config_gypi.py", line 32, in get_gn_config
gn_args = subprocess.check_output(
^^^^^^^^^^^^^^^^^^^^^^^^
File "/nix/store/26yi95240650jxp5dj78xzch70i1kzlz-python3-3.12.9/lib/python3.12/subprocess.py", line 468, in check_output
return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/nix/store/26yi95240650jxp5dj78xzch70i1kzlz-python3-3.12.9/lib/python3.12/subprocess.py", line 550, in run
with Popen(*popenargs, **kwargs) as process:
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/nix/store/26yi95240650jxp5dj78xzch70i1kzlz-python3-3.12.9/lib/python3.12/subprocess.py", line 1028, in __init__
self._execute_child(args, executable, preexec_fn, close_fds,
File "/nix/store/26yi95240650jxp5dj78xzch70i1kzlz-python3-3.12.9/lib/python3.12/subprocess.py", line 1963, in _execute_child
raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'gn'
(cherry picked from commit 2a66805)
FAILED: gen/third_party/electron_node/config.gypi
python3 ../../third_party/electron_node/tools/generate_config_gypi.py gen/third_party/electron_node/config.gypi --out-dir . --dep-file gen/third_party/electron_node/generate_config_gypi.d --node-gn-path //third_party/electron_node
Traceback (most recent call last):
File "/build/src/out/Release/../../third_party/electron_node/tools/generate_config_gypi.py", line 113, in <module>
main()
File "/build/src/out/Release/../../third_party/electron_node/tools/generate_config_gypi.py", line 105, in main
f.write(repr(translate_config(args.out_dir, config, v8_config)))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/build/src/out/Release/../../third_party/electron_node/tools/generate_config_gypi.py", line 62, in translate_config
'node_module_version': int(config['node_module_version']),
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: invalid literal for int() with base 10: '"133"'
Co-authored-by: Ljuzig <diamond.bertelli@gmail.com>
(cherry picked from commit 5213e7e)
13 tasks
|
TomaSajt
approved these changes
Mar 24, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bot-based backport to
release-24.11, triggered by a label in #387294.