Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{roon-tui,rmenu,rtz,rustplayer,ripgrep-all}: use fetchCargoVendor #392751

Merged
merged 5 commits into from
Mar 25, 2025

Conversation

TomaSajt
Copy link
Contributor

This PR migrates a few packages to use fetchCargoVendor.

There have been previous attempts at migrating larger chunks of packages, but I believe smaller chunks are more reviewable.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@LordGrimmauld
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 392751


x86_64-linux

✅ 5 packages built:
  • ripgrep-all
  • rmenu
  • roon-tui
  • rtz
  • rustplayer

Copy link
Contributor

@LordGrimmauld LordGrimmauld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Packages seem to fetch the sources correctly and still build, lgtm

@wegank wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Mar 24, 2025
@JohnRTitor
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 392751

Logs: https://github.com/JohnRTitor/nixpkgs-review-gha/actions/runs/14051398366


x86_64-linux

✅ 5 packages built:
  • ripgrep-all
  • rmenu
  • roon-tui
  • rtz
  • rustplayer

aarch64-linux

✅ 5 packages built:
  • ripgrep-all
  • rmenu
  • roon-tui
  • rtz
  • rustplayer

x86_64-darwin

✅ 3 packages built:
  • ripgrep-all
  • roon-tui
  • rtz

aarch64-darwin

✅ 3 packages built:
  • ripgrep-all
  • roon-tui
  • rtz

@JohnRTitor
Copy link
Contributor

Merging, as this a simple non breaking change.

@JohnRTitor JohnRTitor merged commit 090bfb5 into NixOS:master Mar 25, 2025
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants