hifile: 0.9.9.19 -> 0.9.9.23, make overridable #392759
Open
+5
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hifile
to0.9.9.23
, fixes the broken build caused by the0.9.9.19
appimage not being available anymoreI found these changes to be necessary as hifile only keeps the last 3 versions available for download on their download site. This and the auto-updating being slow process resulted in hifile
0.9.9.19
not being available anymore and causing a build failure.To combat this in the future, I've made changes so that the user could temporarily manually override the version and related hash locally, using an overlay, like so:
These changes are reflected in the updater script as well to not cause issues.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.