Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hifile: 0.9.9.19 -> 0.9.9.23, make overridable #392759

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ymstnt
Copy link
Contributor

@ymstnt ymstnt commented Mar 24, 2025

  • Updated hifile to 0.9.9.23, fixes the broken build caused by the 0.9.9.19 appimage not being available anymore
  • Made changes in how the version and hash is defined, so it can be easily overridden by the user using an overlay
  • Simplified the update script to work with said changes

I found these changes to be necessary as hifile only keeps the last 3 versions available for download on their download site. This and the auto-updating being slow process resulted in hifile 0.9.9.19 not being available anymore and causing a build failure.
To combat this in the future, I've made changes so that the user could temporarily manually override the version and related hash locally, using an overlay, like so:

(final: prev: {
  hifile = prev.hifile.override {
    version = "0.9.9.23";
    hash = "";
  };
})

These changes are reflected in the updater script as well to not cause issues.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Mar 24, 2025
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5308

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants