Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{pw-viz,wl-gammarelay-rs,woomer,cjdns}: use fetchCargoVendor #392775

Merged
merged 4 commits into from
Mar 24, 2025

Conversation

TomaSajt
Copy link
Contributor

This PR migrates a few packages to use fetchCargoVendor.

There have been previous attempts at migrating larger chunks of packages, but I believe smaller chunks are more reviewable.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@diogotcorreia
Copy link
Member

I've opened a PR to do this on pgvecto-rs a few hours ago 😅
#392734
I guess remove it from this PR

@TomaSajt
Copy link
Contributor Author

Okay

@TomaSajt TomaSajt force-pushed the cargo-lockfile-cleaning-misc branch from d564d0f to 2733cb9 Compare March 24, 2025 17:17
@TomaSajt TomaSajt changed the title {pw-viz,wl-gammarelay-rs,postgresql15Packages.pgvectro-rs,woomer,cjdns}: use fetchCargoVendor {pw-viz,wl-gammarelay-rs,woomer,cjdns}: use fetchCargoVendor Mar 24, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 and removed 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Mar 24, 2025
@wolfgangwalther
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 392775


x86_64-linux

✅ 4 packages built:
  • cjdns
  • pw-viz
  • wl-gammarelay-rs
  • woomer

aarch64-linux

⏩ 2 packages marked as broken and skipped:
  • cjdns
  • woomer
✅ 2 packages built:
  • pw-viz
  • wl-gammarelay-rs

@wolfgangwalther wolfgangwalther merged commit e0d8795 into NixOS:master Mar 24, 2025
33 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants