Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixosTests.forgejo{,-lts}: migrate to runTest #392797

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

emilylange
Copy link
Member

This is part of the bigger handleTest deprecation.

See #386873 and #383870 (7e3c668).

Figured we can drop the listToAttrs (map makeForgejoTest supportedDbTypes) and just list them one by one to increase readability and not having to awkwardly pass listToAttrs to the import in all-tests.nix.
If someone disagrees with this or has some better idea, let me know. Open to change it.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

This is part of the bigger handleTest deprecation.

See 7e3c668.
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 24, 2025
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 24, 2025
Copy link
Contributor

@adamcstephens adamcstephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x86

➜ nom-build -A forgejo-lts.passthru.tests -A forgejo.passthru.tests
Finished at 07:54:42 after 38s
/nix/store/srxn3afs7hlrky1nx2scgblib50l8rbq-vm-test-run-forgejo-mysql
/nix/store/95n6qmakasiiwzc971sjwib6r1l2m9sy-vm-test-run-forgejo-postgres
/nix/store/09rxvh866mi1hpb1378ivsxpxsb76mxx-vm-test-run-forgejo-sqlite3
/nix/store/c2vbqlzxqs9861j8qa6f7zjqqi7r808c-vm-test-run-forgejo-mysql
/nix/store/y5zzzgkpvb370fg1x5jgwqqyxff9mrvm-vm-test-run-forgejo-postgres
/nix/store/pnkhxpks06vy9jyr93i3r8kxkm95fyhm-vm-test-run-forgejo-sqlite3

@adamcstephens adamcstephens merged commit dc9b690 into NixOS:master Mar 25, 2025
31 of 32 checks passed
@emilylange emilylange deleted the forgejo-runTest branch March 25, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants