Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/gnome & nixos/gdm: migration out of x11 #392804

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

s0me1newithhand7s
Copy link
Contributor

Reasons:

since DEs like KDE Plasma 6, GNOME and COMSIC are not designed to be x11-exclusive putting them under services.xserver is misleading; to confirm my point - this PR and this PR exist.
also, GNOME's default is wayland, and x11 sessions is an option, that could be dropped in future.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Mar 24, 2025
@s0me1newithhand7s s0me1newithhand7s self-assigned this Mar 24, 2025
@s0me1newithhand7s s0me1newithhand7s added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Mar 24, 2025
@s0me1newithhand7s s0me1newithhand7s marked this pull request as ready for review March 24, 2025 18:18
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 24, 2025
@stellessia
Copy link
Contributor

Let's freaking go!!! I've waited for that change since I rolled into NixOS. Thank you, my dear friend

@s0me1newithhand7s s0me1newithhand7s requested a review from a team March 24, 2025 18:27
@jtojnar
Copy link
Member

jtojnar commented Mar 24, 2025

Thanks, for doing this.

The change looks reasonable at first glance, though tests should probably be updated as well.

I am currently focusing on GNOME 48 upgrade, will take a deeper look after that is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
Status: Nice to have
Development

Successfully merging this pull request may close these issues.

3 participants