nixos/doc: include extensions in postgresql upgrade script #392831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
github-actions
bot
added
10.rebuild-darwin: 0
Comment on lines
210
to
212
| export OLDBIN="${ | ||
| if cfg.extensions == [ ] then cfg.package else cfg.package.withPackages cfg.extensions | ||
| }/bin" |
There was a problem hiding this comment.
IIUC, this should be the same?
Suggested change
| export OLDBIN="${ | |
| if cfg.extensions == [ ] then cfg.package else cfg.package.withPackages cfg.extensions | |
| }/bin" | |
| export OLDBIN="${cfg.finalPackage}/bin" |
There was a problem hiding this comment.
Thanks! I missed that this has been added 👍
13 tasks
kai-tub
force-pushed
the
nixos/doc/postgresql
branch
from
989a2c5 to
4867d68
Compare
Ma27
reviewed
Mar 25, 2025
| @@ -207,15 +207,15 @@ For an upgrade, a script like this can be used to simplify the process: | |||
| export NEWBIN="${newPostgres}/bin" | |||
There was a problem hiding this comment.
At least for pg_anon you need the extensions here as well.
Though this was IIRC the case where you also need specify shared_preload_libraries yourself and this is maybe worth a mention and doesn't really need to be generalized here, does it?
There was a problem hiding this comment.
newPostgres is defined as this further up:
newPostgres = pkgs.postgresql_13.withPackages (pp: [
# pp.plv8
]);
You'd put the extensions here, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.