nixos/cosmic-greeter: init; nixos/cosmic: init

[thefossguy]

Initialize the cosmic modules so the state of broken-ness (or not) of any packages in nixpkgs can be tested. Will add changelog entry to release notes only after the DE functions "as expected."

This will help test the packages and bring out bugs like following:

Mar 25 01:18:22 matsya cosmic-session[1923]: thread 'main' panicked at 'failed to start cosmic-idle': src/main.rs:560
[---snip---]
Mar 25 01:18:23 matsya .cosmic-comp-wrapped[2045]: Unable to parse your locale: ParserError(InvalidLanguage)
Mar 25 01:18:23 matsya .cosmic-comp-wrapped[2045]: Failed to read config 'workspaces'
[---snip---]
Mar 25 01:18:23 matsya .cosmic-comp-wrapped[2045]: shortcuts custom config error: GetKey("custom", Os { code: 2, kind: NotFound, message: "No such file or directory" })

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[thefossguy]

Closes #369113.

[nrabulinski]

If you're copying @lilyinstarlight's work verbatim, at least have the dignity of adding a Co-authored-by

[nyabinary]

The PR title should probably be named as nixos/cosmic-greeter: init; nixos/cosmic: init
Furthermore, please credit @lilyinstarlight as many others have said :P

[thefossguy]

If you're copying @lilyinstarlight's work verbatim, at least have the dignity of adding a Co-authored-by

You don't need to attack anyone to get your point across. Could have mentioned the same thing without assuming I'm a bad guy. My libcosmicAppHook PR was the first to attribute Lily so don't paint me as a bad guy. The earlier PRs from me did not attribute Lily because I'm not at all familiar with software copyrights and didn't know how to do it properly. I asked Lily how the "header" should look like and it resulted in this.

I woke up and the first thing I read about this PR is feedback in form of accusation some good ol' character assassination. :/
I might be an idiot in but I'm not a malicious actor.

[thefossguy]

@HeitorAugustoLN @nyabinary added comments attributing code to Lily and added an option in the cosmic-greeter and cosmic modules to configure the greeter package used.

[ahoneybun]

@ALL let's take a step back on the replies about the lack of credit to Lily a little bit. It is possible that @thefossguy just forgot to add it in this PR which is a simple mistake.

@thefossguy since the credit was added for this PR I think everyone expected it to also be included in this PR as well which caused the reaction.

[thefossguy]

Resolved a few suggestions which I have made modifications for locally. Waiting on the documentation one for clarification so I can push.

[thefossguy]

Pushed with all requested changes addressed.

[nyabinary]

Can I also be added as a maintainer btw? :3

[thefossguy]

@nyabinary done :)

[thefossguy]

Noticed that i missed the cosmic-idle package. The force push before this comment adds the cosmic-idle package.

[thefossguy]

Is this good enough to merge?

[GaetanLepage]

LGTM, thanks for the great work!

I would like an extra committer to ack this before merging.

[JohnRTitor]

Sure, I can take a look tonight.