docker-compose: fix rm
command argument
#392853
Merged
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix a minor argument error in the docker compose derivation. Also discussed here #196654 (comment).
As you can see in the compose file tree here for this tag
e2e
package is actually under thepkg
directory, meaning:pkg/e2e
.Using
rm -rf e2e/
is a silent error: the code will try to remove a nonexistent directory. In this case the build only passes becausedoCheck = false
even though there is a directorypkg/e2e
. If one wants to perform the tests and set it to true this will fail due to the e2e package.To test:
doCheck = true
rm -rf pkg/e2e/
inpostPatch
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.