Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix squirreldisk #392876

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix squirreldisk #392876

wants to merge 1 commit into from

Conversation

peret
Copy link
Contributor

@peret peret commented Mar 24, 2025

Currently the squirreldisk package is broken - it scans the directory, but does not display the results correctly (i.e., no graph and no file sizes are displayed).
The reason is that parallel-disk-usage from nixpkgs has been updated to a version that does not work with squirreldisk anymore (i.e. changed JSON output format).
The package now uses the binary of pdu that is distributed with the squirreldisk source, instead of the version from nixpkgs.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Currently the squirreldisk package is broken - it scans the directory,
but does not display the results correctly (i.e., no graph and no file
sizes are displayed).
The reason is that parallel-disk-usage from nixpkgs has been updated to
a version that does not work with squirreldisk anymore (i.e. changed
JSON output format).
The package now uses the binary of pdu that is distributed with
the squirreldisk source, instead of the version from nixpkgs.
@peret peret force-pushed the fix-squirreldisk branch from 17833d3 to 078ffe0 Compare March 24, 2025 21:32
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Mar 24, 2025
@peret peret requested a review from jtojnar March 24, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant