Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

you-have-mail-cli: use cargoDepsCopy shell variable, use fetchCargoVendor #392881

Merged
merged 2 commits into from
Mar 25, 2025

Conversation

TomaSajt
Copy link
Contributor

We shouldn't rely on the name of the directory, as that's an implementation detail.

cargoDepsCopy gets unset after postPatch runs, so we have to use it in postPatch

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

(cherry picked from commit 8bc679a6e13cdba706bb2c649ddbc9eb2ba63900)
(cherry picked from commit 535ec691679b38f9204677451ecb5177a586aee0)
@JohnRTitor
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 392881

Logs: https://github.com/JohnRTitor/nixpkgs-review-gha/actions/runs/14051379665


x86_64-linux

✅ 1 package built:
  • you-have-mail-cli

aarch64-linux

✅ 1 package built:
  • you-have-mail-cli

x86_64-darwin

✅ 1 package built:
  • you-have-mail-cli

aarch64-darwin

✅ 1 package built:
  • you-have-mail-cli

Copy link
Contributor

@JohnRTitor JohnRTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging, as this a simple non breaking change.

@JohnRTitor JohnRTitor merged commit 35a3805 into NixOS:master Mar 25, 2025
26 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants