python312Packages.colbert-ai: fix import, mark as broken on darwin #392891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GaetanLepage
force-pushed
the
colbert-ai
branch
from
a6cf1b8 to
f96eda8
Compare
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
added
10.rebuild-darwin: 0
|
GaetanLepage
changed the title
NickCao
reviewed
Mar 24, 2025
Comment on lines
+78
to
+80
| # `import torch.distributed.tensor` fails on darwin: | ||
| # ModuleNotFoundError: No module named 'torch._C._distributed_c10d'; 'torch._C' is not a packag | ||
| lib.systems.inspect.patterns.isDarwin |
There was a problem hiding this comment.
This has been manifested in multiple packages, better find a root cause!
There was a problem hiding this comment.
Maybe because of our recent change in pytorch... I hope not.
NickCao
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
cc @bachp
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.