Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemtap-sdt: init #392921

Merged
merged 1 commit into from
Mar 25, 2025
Merged

systemtap-sdt: init #392921

merged 1 commit into from
Mar 25, 2025

Conversation

lf-
Copy link
Member

@lf- lf- commented Mar 25, 2025

This is an API-stable alias for "systemtap just for creating trace points". The use case for this is that the main systemtap package has an annoyingly large closure size of Linux version dependent stuff, which is unnecessary for building trace points.

I am adding this after needing the same override for Lix.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@lf- lf- requested review from bendlas and emilazy March 25, 2025 00:35
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Mar 25, 2025
@lf-
Copy link
Member Author

lf- commented Mar 25, 2025

hmmmmmm on further thought i should rename it to systemtap-sdt for consistency with Debian.

This is an API-stable alias for "systemtap *just* for creating trace
points". The use case for this is that the main systemtap package has an
annoyingly large closure size of Linux version dependent stuff, which is
unnecessary for building trace points.

I am adding this after needing the same override for Lix.
@lf- lf- force-pushed the jade/systemtap-dtrace branch from ff3bf26 to ef09fa1 Compare March 25, 2025 16:57
@lf- lf- changed the title systemtap-dtrace: init systemtap-sdt: init Mar 25, 2025
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 25, 2025
@lf- lf- merged commit e6c4e04 into NixOS:master Mar 25, 2025
34 of 38 checks passed
@lf- lf- added the backport release-24.11 Backport PR automatically label Mar 25, 2025
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Mar 25, 2025

Backport failed for release-24.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.11
git worktree add -d .worktree/backport-392921-to-release-24.11 origin/release-24.11
cd .worktree/backport-392921-to-release-24.11
git switch --create backport-392921-to-release-24.11
git cherry-pick -x ef09fa109256ddd1ab4ea3d5c4f8862ef067ee64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants