Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

krep: init at 0.1.7 #392965

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

krep: init at 0.1.7 #392965

wants to merge 1 commit into from

Conversation

codebam
Copy link
Contributor

@codebam codebam commented Mar 25, 2025

https://github.com/davidesantangelo/krep is a search tool, similar to grep.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@codebam
Copy link
Contributor Author

codebam commented Mar 25, 2025

This is tested and working. Let me know if anything needs to be done

@awwpotato
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 392965


x86_64-linux

✅ 1 package built:
  • krep

Copy link
Contributor

@awwpotato awwpotato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the bin seems to be fully working

@awwpotato awwpotato added the 8.has: package (new) This PR adds a new package label Mar 25, 2025
@codebam
Copy link
Contributor Author

codebam commented Mar 25, 2025

Changed as requested, thanks. Let me know if there's anything else

@codebam
Copy link
Contributor Author

codebam commented Mar 25, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 392965


x86_64-linux

✅ 1 package built:
  • krep

Copy link
Contributor

@awwpotato awwpotato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants