gst_all_1.gst-plugins-good: fix build for musl #393037
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
10.rebuild-darwin: 11-100
10.rebuild-linux: 1001-2500
10.rebuild-linux: 501+
and removed
6.topic: musl
jtojnar
approved these changes
Mar 25, 2025
| (fetchpatch { | ||
| name = "musl.patch"; | ||
| url = "https://gitlab.freedesktop.org/gstreamer/gstreamer/-/commit/dd1fc2b7931f5789815e17dda2ef7c31b9fba563.patch"; | ||
| stripLen = 2; |
There was a problem hiding this comment.
Surprised this is enough without extraPrefix = ""; to add a/ and b/ prefixes.
There was a problem hiding this comment.
It's because it leaves the "gst-plugins-good/" prefix, which functions the same as a/ and b/ would.
Pretty sure it will. I just missed out on getting it into 1.26.0. (My other musl fix submitted just before did make it — that was a fix for a regression introduced after 1.24 so we don't need to worry about it.) |
wegank
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.