Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/dependency-track: fix nginx config for frontend #393041

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xanderio
Copy link
Contributor

Apparend I fell for some browser cache when implementing this in the first place. This patch is based on the upstream nginx config.

https://github.com/DependencyTrack/frontend/blob/5f318aca10f85f1f5d7a91d7627883bd506cc48e/docker/etc/nginx/templates/default.conf.template

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 25, 2025
@xanderio xanderio force-pushed the push-xrqnyxrruvms branch 2 times, most recently from c8227cc to 4592e2d Compare March 25, 2025 11:40
Apparend I fell for some browser cache when implementing this in the
first place. This patch is based on the upstream nginx config.

https://github.com/DependencyTrack/frontend/blob/5f318aca10f85f1f5d7a91d7627883bd506cc48e/docker/etc/nginx/templates/default.conf.template
@xanderio xanderio force-pushed the push-xrqnyxrruvms branch from 4592e2d to d690c2c Compare March 25, 2025 11:42
Copy link
Contributor

@blitz blitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get the fix merged!

Did the broken change get backported? If so, we should also backport this. Also, is there a test that catches misconfigurations like this?

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants