Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treewide: add missing and fix dead homepages #393043

Merged
merged 7 commits into from
Mar 26, 2025
Merged

treewide: add missing and fix dead homepages #393043

merged 7 commits into from
Mar 26, 2025
+10 −7

Conversation

jopejoe1
Copy link
Member

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 25, 2025
Aleksanaa
Aleksanaa approved these changes Mar 26, 2025
View reviewed changes
pkgs/by-name/wa/watson/package.nix
@@ -13,17 +13,17 @@ buildPythonApplication rec {
version = "2.1.0";

src = fetchFromGitHub {
owner = "TailorDev";
owner = "jazzband";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: repo transferred

@Aleksanaa Aleksanaa added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 26, 2025
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 26, 2025
@jopejoe1 jopejoe1 force-pushed the missing-homepages-2 branch from 2ed2027 to 1039a2e Compare March 26, 2025 19:44
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 26, 2025
@jopejoe1 jopejoe1 merged commit 4f61fd5 into NixOS:master Mar 26, 2025
25 of 29 checks passed
@jopejoe1 jopejoe1 deleted the missing-homepages-2 branch March 26, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aleksanaa Aleksanaa

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jopejoe1 @Aleksanaa @wegank