nixos/nextcloud: add maintainer team, update docs about maintainership of apps #393069
Conversation
* Create a dedicated team. Before, information was inconsistent between e.g. tests and package, module had none at all. * Add maintainership from us to all trivially packaged apps. This is only to make sure that we take care of them building and installing and that's about it.
Realized that this is something, I discussed with Benedikt, but wasn't written down somewhere.
github-actions
bot
added
6.topic: nixos
There was a problem hiding this comment.
btw @provokateurin one thing I haven't touched here is the nextcloud-news-updater package. This hasn't been touched upstream for ~4 years, so is this something that even makes sense to keep around here?
| members = [ | ||
| bachp | ||
| britter | ||
| dotlambda |
There was a problem hiding this comment.
@dotlambda in my head you've been a maintainer and I just got reminded that you aren't. Given you're doing quite a lot of stuff, I figured I could add you. If that's not OK, let me know and I'll remove you again!
| britter | ||
| dotlambda | ||
| ma27 | ||
| ]; |
There was a problem hiding this comment.
@provokateurin you started quite recently doing Nextcloud work here as well. Given this and you knowing the codebase way better than we do as developer, you'd be very welcome as member here. Let me know if you're interested and I'd add you.
| maintainers = with lib.maintainers; [ | ||
| schneefux | ||
| bachp | ||
| globin |
There was a problem hiding this comment.
@globin @schneefux since I don't recall you doing NC maintenance in the past years(?), I didn't add you to the team. If you want to be part of regardless, let me know.
github-actions
bot
added
10.rebuild-darwin: 0
I have no idea to be honest. I'm using the news app on my instance, but never used this package (neither with NixOS nor outside of it). Maybe we should skip it for now (or even remove it?) and revisit it later, to see if still works or not. |
|
I had a closer look and the source has also not seen any activity in the last 4 years: https://github.com/nextcloud/news-updater. I assume, that not that many people are using it at all. |
tl;dr
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.