[staging] python3.pkgs.sphinx-issues: avoid use of pandoc in build closure (riscv64-fix) #393093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
changed the title
Shipping an HTML version of the Readme for a library is a bit uncommon in nixpkgs. We don't do this for any other package because it will also a bit awkward to access directly (libraries don't get included into environment.systemPackages directly for instance). Including pandoc in the build closure makes this derivation unusuable on riscv64 and other platforms that are not supported by ghc. Since this package is now part of NixOS integration tests this break evaluation of all riscv64-based NixOS tests.
Mic92
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shipping an HTML version of the Readme for a library is a bit uncommon in nixpkgs.
We don't do this for any other package because it will also a bit
awkward to access directly (libraries don't get included into
environment.systemPackages directly for instance).
Including pandoc in the build closure makes this derivation unusuable on riscv64 and other platforms
that are not supported by ghc.
Since this package is now part of NixOS integration tests this break
evaluation of all riscv64-based NixOS tests.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.