Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fwupd: 2.0.6 -> 2.0.7 #393130

Merged
merged 1 commit into from
Mar 25, 2025
Merged

fwupd: 2.0.6 -> 2.0.7 #393130

merged 1 commit into from
Mar 25, 2025

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Mar 25, 2025

Things done

Changelog: https://github.com/fwupd/fwupd/releases/tag/2.0.7

cc @r-vdp

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Mar 25, 2025
@nix-owners nix-owners bot requested a review from r-vdp March 25, 2025 16:54
@GaetanLepage
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 393130


x86_64-linux

⏩ 2 packages marked as broken and skipped:
  • libsForQt5.discover
  • plasma5Packages.discover
✅ 26 packages built:
  • fwupd
  • fwupd.debug
  • fwupd.dev
  • fwupd.devdoc
  • fwupd.installedTests
  • fwupd.lib
  • fwupd.man
  • gnome-firmware
  • gnome-software
  • kdePackages.discover
  • kdePackages.discover.debug
  • kdePackages.discover.dev
  • kdePackages.discover.devtools
  • libsForQt5.kinfocenter (plasma5Packages.kinfocenter)
  • pantheon.elementary-greeter
  • pantheon.elementary-onboarding
  • pantheon.elementary-settings-daemon
  • pantheon.switchboard-plug-about
  • pantheon.switchboard-plug-pantheon-shell
  • pantheon.switchboard-plug-power
  • pantheon.switchboard-plug-security-privacy
  • pantheon.switchboard-with-plugs
  • pantheon.wingpanel-applications-menu
  • pantheon.wingpanel-indicator-power
  • pantheon.wingpanel-quick-settings
  • pantheon.wingpanel-with-indicators

aarch64-linux

⏩ 2 packages marked as broken and skipped:
  • libsForQt5.discover
  • plasma5Packages.discover
❌ 25 packages failed to build:
  • fwupd
  • fwupd.debug
  • fwupd.dev
  • fwupd.devdoc
  • fwupd.installedTests
  • fwupd.lib
  • fwupd.man
  • gnome-firmware
  • kdePackages.discover
  • kdePackages.discover.debug
  • kdePackages.discover.dev
  • kdePackages.discover.devtools
  • libsForQt5.kinfocenter (plasma5Packages.kinfocenter)
  • pantheon.elementary-greeter
  • pantheon.elementary-onboarding
  • pantheon.elementary-settings-daemon
  • pantheon.switchboard-plug-about
  • pantheon.switchboard-plug-pantheon-shell
  • pantheon.switchboard-plug-power
  • pantheon.switchboard-plug-security-privacy
  • pantheon.switchboard-with-plugs
  • pantheon.wingpanel-applications-menu
  • pantheon.wingpanel-indicator-power
  • pantheon.wingpanel-quick-settings
  • pantheon.wingpanel-with-indicators

@flokli flokli self-requested a review March 25, 2025 17:15
Copy link
Contributor

@flokli flokli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aarch64-linux fails with:

       > meson.build:1:0: ERROR: Unknown options: "plugin_msr, plugin_redfish, plugin_synaptics_mst"

@GaetanLepage
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 393130


x86_64-linux

⏩ 2 packages marked as broken and skipped:
  • libsForQt5.discover
  • plasma5Packages.discover
✅ 26 packages built:
  • fwupd
  • fwupd.debug
  • fwupd.dev
  • fwupd.devdoc
  • fwupd.installedTests
  • fwupd.lib
  • fwupd.man
  • gnome-firmware
  • gnome-software
  • kdePackages.discover
  • kdePackages.discover.debug
  • kdePackages.discover.dev
  • kdePackages.discover.devtools
  • libsForQt5.kinfocenter (plasma5Packages.kinfocenter)
  • pantheon.elementary-greeter
  • pantheon.elementary-onboarding
  • pantheon.elementary-settings-daemon
  • pantheon.switchboard-plug-about
  • pantheon.switchboard-plug-pantheon-shell
  • pantheon.switchboard-plug-power
  • pantheon.switchboard-plug-security-privacy
  • pantheon.switchboard-with-plugs
  • pantheon.wingpanel-applications-menu
  • pantheon.wingpanel-indicator-power
  • pantheon.wingpanel-quick-settings
  • pantheon.wingpanel-with-indicators

aarch64-linux

⏩ 2 packages marked as broken and skipped:
  • libsForQt5.discover
  • plasma5Packages.discover
✅ 25 packages built:
  • fwupd
  • fwupd.debug
  • fwupd.dev
  • fwupd.devdoc
  • fwupd.installedTests
  • fwupd.lib
  • fwupd.man
  • gnome-firmware
  • kdePackages.discover
  • kdePackages.discover.debug
  • kdePackages.discover.dev
  • kdePackages.discover.devtools
  • libsForQt5.kinfocenter (plasma5Packages.kinfocenter)
  • pantheon.elementary-greeter
  • pantheon.elementary-onboarding
  • pantheon.elementary-settings-daemon
  • pantheon.switchboard-plug-about
  • pantheon.switchboard-plug-pantheon-shell
  • pantheon.switchboard-plug-power
  • pantheon.switchboard-plug-security-privacy
  • pantheon.switchboard-with-plugs
  • pantheon.wingpanel-applications-menu
  • pantheon.wingpanel-indicator-power
  • pantheon.wingpanel-quick-settings
  • pantheon.wingpanel-with-indicators

@GaetanLepage GaetanLepage requested a review from flokli March 25, 2025 17:33
@flokli
Copy link
Contributor

flokli commented Mar 25, 2025

passthru.filesInstalledToEtc should probably be sorted, so it's easier to compare with a find result/etc output, but that can be left to a followup.

@flokli flokli merged commit 9a8852d into NixOS:master Mar 25, 2025
57 of 61 checks passed
Comment on lines -87 to -97
# Dell isn't supported on Aarch64
haveDell = isx86;

# only redfish for x86_64
haveRedfish = stdenv.hostPlatform.isx86_64;

# only use msr if x86 (requires cpuid)
haveMSR = isx86;

# # Currently broken on Aarch64
# haveFlashrom = isx86;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened to these?
I'm on mobile, so I couldn't check the upstream diff yet.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just saw the discussion above now. These were removed upstream?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redfish seems to work for all Linux now: fwupd/fwupd@ad1e0dc

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

synaptics-mst I see as an enabled plugin in the build log, on aarch64-linux and x86_64-linux:

aarch64-linux:

    enabled                   : acpi-phat, algoltek-usb, algoltek-usbcr, amd-gpu, amd-kria, analogix, android-boot, asus-hid, ata, aver-hid, bcm57xx, bnr-dp, ccgx, ccgx-dmc, cfu, ch341a, ch347, corsair, cpu, cros-ec, dell, dell-dock, dell-kestrel, dfu, ebitdo, elan-kbd, elanfp, elantp, emmc, ep963x, fastboot, focalfp, fpc, fresco-pd, genesys, genesys-gl32xx, goodix-moc, goodix-tp, gpio, hailuck, hpi-cfu, huddly-usb, hughski-colorhug, intel-cvs, intel-gsc, intel-me, intel-usb4, jabra, jabra-file, jabra-gnp, kinetic-dp, legion-hid2, lenovo-thinklmi, linux-display, linux-lockdown, linux-swap, linux-tainted, logind, logitech-bulkcontroller, logitech-hidpp, logitech-rallysystem, logitech-scribe, logitech-tap, mediatek-scaler, modem-manager, mtd, nordic-hid, nvme, optionrom, parade-lspcon, parade-usbhub, pci-bcr, pci-mei, pixart-rf, powerd, qc-s5gen2, qsi-dock, realtek-mst, redfish, rp-pico, rts54hid, rts54hub, scsi, steelseries, synaptics-cape, synaptics-cxaudio, synaptics-mst, synaptics-prometheus, synaptics-rmi, synaptics-vmm9, system76-launch, telink-dfu, test, thelio-io, ti-tps6598x, tpm, uefi-capsule, uefi-dbx, uefi-esrt, uefi-mok, uefi-pk, uefi-recovery, uefi-sbat, uf2, upower, usi-dock, vbe, vli, wacom-raw, wacom-usb, wistron-dock
    disabled                  : acpi-dmar, acpi-facp, acpi-ivrs, amd-pmc, bios, flashrom, iommu, linux-sleep, msr, pci-psp, qc-firehose, thunderbolt

x86_64-linux:

    enabled                   : acpi-dmar, acpi-facp, acpi-ivrs, acpi-phat, algoltek-usb, algoltek-usbcr, amd-gpu, amd-kria, amd-pmc, analogix, android-boot, asus-hid, ata, aver-hid, bcm57xx, bios, bnr-dp, ccgx, ccgx-dmc, cfu, ch341a, ch347, corsair, cpu, cros-ec, dell, dell-dock, dell-kestrel, dfu, ebitdo, elan-kbd, elanfp, elantp, emmc, ep963x, fastboot, focalfp, fpc, fresco-pd, genesys, genesys-gl32xx, goodix-moc, goodix-tp, gpio, hailuck, hpi-cfu, huddly-usb, hughski-colorhug, intel-cvs, intel-gsc, intel-me, intel-usb4, iommu, jabra, jabra-file, jabra-gnp, kinetic-dp, legion-hid2, lenovo-thinklmi, linux-display, linux-lockdown, linux-sleep, linux-swap, linux-tainted, logind, logitech-bulkcontroller, logitech-hidpp, logitech-rallysystem, logitech-scribe, logitech-tap, mediatek-scaler, modem-manager, msr, mtd, nordic-hid, nvme, optionrom, parade-lspcon, parade-usbhub, pci-bcr, pci-mei, pci-psp, pixart-rf, powerd, qc-s5gen2, qsi-dock, realtek-mst, redfish, rp-pico, rts54hid, rts54hub, scsi, steelseries, synaptics-cape, synaptics-cxaudio, synaptics-mst, synaptics-prometheus, synaptics-rmi, synaptics-vmm9, system76-launch, telink-dfu, test, thelio-io, thunderbolt, ti-tps6598x, tpm, uefi-capsule, uefi-dbx, uefi-esrt, uefi-mok, uefi-pk, uefi-recovery, uefi-sbat, uf2, upower, usi-dock, vbe, vli, wacom-raw, wacom-usb, wistron-dock
    disabled                  : flashrom, qc-firehose

@GaetanLepage GaetanLepage deleted the fwupd branch March 25, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants