Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pqiv: include darwin in platform list #393197

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tennysontbardwell
Copy link

@tennysontbardwell tennysontbardwell commented Mar 25, 2025

I had no issues building this on a Mac M1. This is my personal config:

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
      • nix-info output says sandbox = no
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/
    nixpkgs-review#usage)
    • not needed because we are going from a non-building state to a building state, no downstream builds could exist to be broken
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@donovanglover

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Mar 25, 2025
@tennysontbardwell
Copy link
Author

I was able to open pqiv and view images without issue

@github-actions github-actions bot added 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 25, 2025
@nix-owners nix-owners bot requested a review from donovanglover March 25, 2025 20:38
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Mar 25, 2025
@ofalvai
Copy link
Contributor

ofalvai commented Mar 26, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 393197


x86_64-darwin

✅ 1 package built:
  • pqiv

aarch64-darwin

✅ 1 package built:
  • pqiv

Copy link
Member

@donovanglover donovanglover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you change the commit message to use : instead of --?

@@ -42,7 +42,7 @@ stdenv.mkDerivation (finalAttrs: {
homepage = "https://www.pberndt.com/Programme/Linux/pqiv";
license = licenses.gpl3Plus;
maintainers = with maintainers; [ donovanglover ];
platforms = platforms.linux;
platforms = platforms.all;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
platforms = platforms.all;
platforms = platforms.unix;

Covers linux and darwin

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@donovanglover I have made your suggested change (all -> unix, thank you!) and modified the commit message. I did both of these via a git commit --amend and force push. Let me know if that's what you wanted, and if there's anything else!

@tennysontbardwell tennysontbardwell changed the title pqiv -- include darwin in platform list pqiv: include darwin in platform list Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants