-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pqiv: include darwin in platform list #393197
base: master
Are you sure you want to change the base?
Conversation
I was able to open pqiv and view images without issue |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Can you change the commit message to use :
instead of --
?
pkgs/by-name/pq/pqiv/package.nix
Outdated
@@ -42,7 +42,7 @@ stdenv.mkDerivation (finalAttrs: { | |||
homepage = "https://www.pberndt.com/Programme/Linux/pqiv"; | |||
license = licenses.gpl3Plus; | |||
maintainers = with maintainers; [ donovanglover ]; | |||
platforms = platforms.linux; | |||
platforms = platforms.all; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
platforms = platforms.all; | |
platforms = platforms.unix; |
Covers linux
and darwin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@donovanglover I have made your suggested change (all
-> unix
, thank you!) and modified the commit message. I did both of these via a git commit --amend
and force push. Let me know if that's what you wanted, and if there's anything else!
7cb5676
to
fa75619
Compare
I had no issues building this on a Mac M1. This is my personal config: https://github.com/tennysontbardwell/public/blob/master/dotfiles/nix/.config/nix/overlay/pqiv.nix#L45
fa75619
to
5ff2f69
Compare
I had no issues building this on a Mac M1. This is my personal config:
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/nixpkgs-review#usage)
./result/bin/
)@donovanglover
Add a 👍 reaction to pull requests you find important.