python3Packages.dm-tree: cleanup #393216
Merged
python3Packages.dm-tree: cleanup #393216
+5
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
the
2.status: merge conflict
|
Thanks! Can you fix the merge conflict please? |
|
yeah, pulling latest pkgs takes forever, will do soon |
ofborg
bot
removed
the
2.status: merge conflict
|
@GaetanLepage done |
|
Diff LGTM, but I think that it breaks |
|
@ofborg build python312Packages.orbax-checkpoint |
|
yeah, this build is failing |
|
builds now somehow, strange @nixos ➜ nixpkgs git:(dm-tree/fix)
$ nix-build ./. -A python312Packages.orbax-checkpoint
/nix/store/0g6p73d19vasyq494k3swp6pwx6lc8qz-python3.12-orbax-checkpoint-0.11.10 |
|
samuela
reviewed
Mar 26, 2025
There was a problem hiding this comment.
did we forget to remove this in some previous change?
There was a problem hiding this comment.
It smelled like this
GaetanLepage
approved these changes
Mar 26, 2025
wegank
added
the
12.approvals: 1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
address PR #384477 and resolves the issue with missing symbol. The essence of the issue was that abseil-cpp library was built with different flags for dm-tree leading to ldd issues only when used with specific libraries linked for the same process (e.g. pyarrow).
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.
Tagging @GaetanLepage for review