Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netsurf.libdom: fix build on GCC 14 #393229

Merged
merged 1 commit into from
Mar 26, 2025
Merged

netsurf.libdom: fix build on GCC 14 #393229

merged 1 commit into from
Mar 26, 2025

Conversation

petrzjunior
Copy link
Contributor

Pull patch from unreleased upstream which fix calloc argument order error.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@petrzjunior
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 393229

Logs: https://github.com/petrzjunior/nixpkgs-review-gha/actions/runs/14071642674


x86_64-linux

❌ 2 packages failed to build:
  • netsurf-browser (netsurf.browser)
  • netsurf.libsvgtiny
✅ 1 package built:
  • netsurf.libdom

aarch64-linux

❌ 2 packages failed to build:
  • netsurf-browser (netsurf.browser)
  • netsurf.libsvgtiny
✅ 1 package built:
  • netsurf.libdom

x86_64-darwin

✅ 3 packages built:
  • netsurf-browser (netsurf.browser)
  • netsurf.libdom
  • netsurf.libsvgtiny

aarch64-darwin

✅ 3 packages built:
  • netsurf-browser (netsurf.browser)
  • netsurf.libdom
  • netsurf.libsvgtiny

@jopejoe1 jopejoe1 merged commit 359fd5c into NixOS:master Mar 26, 2025
26 of 29 checks passed
@petrzjunior petrzjunior deleted the libdom branch March 26, 2025 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants