-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xrock: init at 1.1.2 #393275
base: master
Are you sure you want to change the base?
xrock: init at 1.1.2 #393275
Conversation
Tested that xrock works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM. Nice work.
Signed-off-by: Felix Singer <felixsinger@posteo.net>
cfe8c27
to
9e42f69
Compare
@NixOS/nixpkgs-merge-bot merge |
@felixsinger merge not permitted (#305350): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A really nice tool, good to have! 🥳
How is it with udev rules? The AUR package installs them:
https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=xrock
no idea what the mechanism would be in Nix though
Will add udev rules in a dedicated pull request. They are not strictly required and the tool works with root as expected. |
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.