test(react-query): use fake timer for HydrationBoundary.test.tsx #8774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit 9fd6fbe.
☁️ Nx Cloud last updated this comment at |
manudeli
force-pushed
the
react-query/test/use-fake-timer-HydrationBoundary
branch
from
2acf617 to
0308e17
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8774 +/- ##
===========================================
- Coverage 46.58% 32.83% -13.76%
===========================================
Files 200 5 -195
Lines 7573 67 -7506
Branches 1740 16 -1724
===========================================
- Hits 3528 22 -3506
+ Misses 3669 37 -3632
+ Partials 376 8 -368
🚀 New features to boost your workflow:
|
TkDodo
reviewed
Mar 11, 2025
Comment on lines
363
to
367
| Array.from({ length: 1000 }).map(async (_, index) => { | ||
| await vi.advanceTimersByTimeAsync(index) | ||
| expect(hydrateSpy).toHaveBeenCalledTimes(0) | ||
| }), | ||
| ) |
There was a problem hiding this comment.
I wanted to test that hydrateSpy is not called over time.
There was a problem hiding this comment.
I think this is better
await vi.runAllTimersAsync()
expect(hydrateSpy).toHaveBeenCalledTimes(0)…e-fake-timer-HydrationBoundary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.