Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Image is not downloading #24632

Open
1 task done
ghost opened this issue Jun 19, 2023 · 3 comments · May be fixed by #34786
Open
1 task done

[Bug]: Image is not downloading #24632

ghost opened this issue Jun 19, 2023 · 3 comments · May be fixed by #34786
Assignees
@Nikhil-Nandagopal @rahulbarwal @somangshu @pranavkanade @dilippitchika @kamakshibhat-appsmith @carinanfonseca
Labels
Bug Something isn't working Image Widget Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage Production Query & Widgets Pod All issues related to Query, JS, Eval, and Widgets Widgets & Accelerators Pod Issues related to widgets & Accelerators Widgets Product This label groups issues related to widgets

Comments

@ghost
Copy link

ghost commented Jun 19, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Description

On clicking download icon on image widget opens up the image in next window but do not allow image to get downloaded
Note : toggle on "enable download" property for image widget

Expected result : When user clicks download icon on image it should allow image to get downloaded and opens up in the next window

Steps To Reproduce

  1. Drag and drop image widget
  2. Toggle on the "Enable download" option
  3. Observe image widget will have download icon on it
  4. Click on download and observe image opens up in next tab but did not get downloaded.

Attached referenced screen shot
image

Public Sample App

No response

Environment

Production

Issue video log

No response

Version

Appsmith v1.9.23-SNAPSHOT
@ghost ghost added Bug Something isn't working Image Widget Production Needs Triaging Needs attention from maintainers to triage Medium Issues that frustrate users due to poor UX labels Jun 19, 2023
@github-actions github-actions bot added Widgets Product This label groups issues related to widgets labels Jun 19, 2023
@colin-precisionos
Copy link

I can confirm this is still happening - I expect the behaviour to trigger the download of the image (not load the image in a new tab)

@Shivam-z
Copy link
Contributor

Shivam-z commented Jul 1, 2024 •
edited
Loading

Hi @Nikhil-Nandagopal I am picking up this issue.
Issue : download attribute opens file instead of downloading because this attribute only works for [same-origin URLs]
https://stackoverflow.com/questions/52089417/anchor-tag-with-download-attribute-opens-file-instead-of-downloading

Approach: The data expected by appsmith Image widget to render is either datasource url or base64, the issue which we currently encountered is only for datasource url and it is perfectly working for base64.
When we give an Image url as data for Image widget then internally we can convert this url to base64 url and attach that base64 Image as href of anchor tag to download the Image properly.

@Nikhil-Nandagopal
Copy link
Contributor

@Shivam-z go for it

@coderabbitai coderabbitai bot linked a pull request Jul 8, 2024 that will close this issue
Open
2 tasks
@Nikhil-Nandagopal Nikhil-Nandagopal added the Widgets & Accelerators Pod Issues related to widgets & Accelerators label Aug 6, 2024
@vivek-appsmith vivek-appsmith added the Query & Widgets Pod All issues related to Query, JS, Eval, and Widgets label Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nikhil-Nandagopal Nikhil-Nandagopal

@rahulbarwal rahulbarwal

@somangshu somangshu

@pranavkanade pranavkanade

@dilippitchika dilippitchika

@kamakshibhat-appsmith kamakshibhat-appsmith

@carinanfonseca carinanfonseca

Labels
Bug Something isn't working Image Widget Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage Production Query & Widgets Pod All issues related to Query, JS, Eval, and Widgets Widgets & Accelerators Pod Issues related to widgets & Accelerators Widgets Product This label groups issues related to widgets
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: fixed image not downloading functionality and ImageWidget cypr… Shivam-z/appsmith
10 participants
@Nikhil-Nandagopal @rahulbarwal @somangshu @pranavkanade @dilippitchika @colin-precisionos @kamakshibhat-appsmith @carinanfonseca @Shivam-z @vivek-appsmith