Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HIDDEN label to privacy.clearOnShutdown_v2.downloads #1947

Open
wants to merge 1 commit into
base: Thorin-Oakenpants-patch-1
Choose a base branch
from

Conversation

rusty-snake
Copy link
Contributor

The merge target is the v136 PR

@Thorin-Oakenpants
Copy link
Contributor

I don't think it's hidden, because regardless of it's setting, it is set at runtime?

@rusty-snake
Copy link
Contributor Author

rusty-snake commented Mar 13, 2025

For me, privacy.clearOnShutdown_v2.downloads gets not set from the dialog clearOnShutdown dialog on about:preference. Neither true nor false. Tried in a new profile.

The sync pref for this pref is not hidden.

@Thorin-Oakenpants
Copy link
Contributor

Thorin-Oakenpants commented Mar 13, 2025

https://searchfox.org/mozilla-central/search?q=clearOnShutdown_v2.downloads&path=&case=false&regexp=false

I need to think more about what triggers this. But sure, it's a "hidden" pref (which I knew cuz it has a recycle bin) - but we've had those before not labelled when they are added by runtimes (IIRC)

edit: IDK if it even does anything by the looks of it

@Thorin-Oakenpants
Copy link
Contributor

Thorin-Oakenpants commented Mar 13, 2025

toggling settings (in the UI) in nightly doesn't create the pref

So in https://phabricator.services.mozilla.com/D194136 scroll down to browser/base/content/sanitize_v2.xhtml line 234 it was added as the pref behind a checkbox called item-download-history at the end under site settings

but if you look at https://searchfox.org/mozilla-central/source/browser/base/content/sanitize_v2.xhtml it's gone

edit: https://bugzilla.mozilla.org/show_bug.cgi?id=1888466#c7 indicates they considered a separate check item

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants