Fix cookiecuttered CI builds #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfitz
requested review from
brynpickering,
syhwawa,
D-Dulius,
Dominic-Duke,
divyasharma-arup and
anarcoteron
mfitz
commented
Mar 26, 2025
| @@ -13,13 +13,16 @@ | |||
| "package_name": "osmox", | |||
| "module_name": "osmox", | |||
| "project_short_description": "A tool for extracting locations and features from OpenStreetMap (OSM) data.", | |||
| "upload_pypi_package": "y", | |||
| "project_visibility": "public", | |||
There was a problem hiding this comment.
If we don't tell cruft that the repo is public, cruft update fails with:
ERROR: 'internal' projects must set the `conda_channel` to: https://packages.arup.com/conda.
Stopping generation because pre_gen_project hook script didn't exit successfully
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
mfitz
commented
Mar 27, 2025
src/osmox/build.py
Outdated
There was a problem hiding this comment.
From here on down, these are linting changes made automatically by pre-commit.ci.
…osmox into fix-cookiecuttered-ci-builds
gac55
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog not updated; this is not a user-facing change.
I used
cruft updateto pull in the latest versions of the cookie-cutter managed workflows.Some of the changes are not related to the cookie-cutter template. When we updated this repo to the latest version of the template (that's essentially what this PR is about), an additional
pre-commit.cicheck was introduced that does a bunch of linting on the code. It blew up with a bunch of complaints about missing dosctrings, unused imports, etc. You can instruct the tool to autofix all of the lining errors, which I did with this comment. The tool then made this commit to fix all of the lining errors it identified.Before
Broken (daily) CI build caused by an invalid workflow file.
After
Passing CI build, albeit using a different workflow file:
Checklist
Any checks which are not relevant to the PR can be pre-checked by the PR creator.
All others should be checked by the reviewer(s).
You can add extra checklist items here if required by the PR.