Skip to content

make to_svg public #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

make to_svg public #4

wants to merge 1 commit into from

Conversation

ubamrein
Copy link

@ubamrein ubamrein commented Aug 7, 2020

No need to have the to_svg function private, or is there?

#1

@martinfrances107
Copy link

martinfrances107 commented Aug 14, 2023

I think this is a good idea

here is a use case

I am using leptos ( a rust web framework inspired by react/sycamore )

For normal react applications, when working with d3 modules it is a standard pattern to use a createEffect() to modify the DOM after react has rendered a component.

if to_svg) were public then leptos apps would not have to use the equivalent createEffect() escape hatch

a string could be prepared as part of the normal render flow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants