[pylint] Avoid flattening nested min/max when outer call has single argument (PLW3301) #16885
+48
−38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes false positives (and incorrect autofixes) in
nested-min-max
(PLW3301
) when the outermin
/max
call only has a single argument. Previously the rule would flatten:into
min([2, 3], [4, 1])
, changing the semantics. The rule now skips any nested call when the outer call has only one positional argument. The pylint fixture and snapshot were updated accordingly.Test Plan
Ran Ruff against the updated
nested_min_max.py
fixture:to verify that
min(min([2, 3], [4, 1]))
andmax(max([2, 4], [3, 1]))
are no longer flagged. Updated the fixture and snapshot; all other existing warnings remain unchanged. The code compiles and the unit tests pass.This PR was generated by an AI system in collaboration with maintainers: @carljm, @ntBre
Fixes #16163