Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check unknown config in configuration file #300

Open
Lee-W opened this issue Nov 12, 2020 · 2 comments
Open

Check unknown config in configuration file #300

Lee-W opened this issue Nov 12, 2020 · 2 comments
Labels
good first issue issue-status: wait-for-implementation maintainers agree on the bug / feature type: feature A new enhacement proposal

Comments

@Lee-W
Copy link
Member

Lee-W commented Nov 12, 2020

Description

Check whether unknown configuration exists in the configuration file when strict_config=True is passed. It should work like --strict-markers in pytest. It can avoid typo in the configuration.

Possible Solution

  1. add strict_config as a configuration
  2. define the valid configurations
  3. check unknown key in base_config if strict_config=True

Additional context

Related Issue

@Lee-W Lee-W added the type: feature A new enhacement proposal label Nov 12, 2020
@woile
Copy link
Member

woile commented Nov 14, 2020

How would this work? What do you envision and what's the use case?

@Lee-W
Copy link
Member Author

Lee-W commented Nov 15, 2020

If any configuration not supported by commitizen exists in the section [tool.commitizen], any commtizen command should fail with an error message saying which configuration is not supported.

Days ago, I tried to reproduce #297, but forget that I didn't have the latest commitizen installed which does not yet support update_changelog_on_bump.

Also, I think it might be great if an user can list all the configuration through cli like pytest --fixtures does.

@Lee-W Lee-W self-assigned this Sep 26, 2021
@Lee-W Lee-W removed the pycontw2021 label Sep 27, 2021
@Lee-W Lee-W mentioned this issue Dec 8, 2021
4 tasks
@Lee-W Lee-W added issue-status: wait-for-implementation maintainers agree on the bug / feature good first issue labels Aug 11, 2024
@Lee-W Lee-W removed their assignment Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue issue-status: wait-for-implementation maintainers agree on the bug / feature type: feature A new enhacement proposal
Projects
None yet
Development

No branches or pull requests

2 participants