Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -Wnewline-eof to match Flutter #60404

Closed
wants to merge 2 commits into from
Closed

Conversation

eseidel
Copy link
Contributor

@eseidel eseidel commented Mar 25, 2025

I'm not sure this is the right place to add this flag, but I couldn't find a better one.

Fixes #60403.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
I'm not sure this is the right place to add this flag, but I couldn't find a better one.

Fixes dart-lang#60403.
Copy link

Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at:

https://dart-review.googlesource.com/c/sdk/+/417863

Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly.

Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR).

Verified

This commit was signed with the committer’s verified signature.
eseidel Eric Seidel
Copy link

https://dart-review.googlesource.com/c/sdk/+/417863 has been updated with the latest commits from this pull request.

1 similar comment
Copy link

https://dart-review.googlesource.com/c/sdk/+/417863 has been updated with the latest commits from this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dart should compile with -Wnewline-eof to match Flutter
1 participant