Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Recheck all in ¨tag-name"' doesn't enqueue PAUSED watches #2934

Open
birukoff opened this issue Jan 27, 2025 · 5 comments
Open

'Recheck all in ¨tag-name"' doesn't enqueue PAUSED watches #2934

birukoff opened this issue Jan 27, 2025 · 5 comments
Assignees
Labels

Comments

@birukoff
Copy link

Describe the bug
Here is a CORRECTED report of the closed issue #2932

The UI has a button called 'Recheck all in ¨_tag-name_"' under the list of watches assigned to a tag. Pressing it doesn't enqueue paused watches for re-checking. The appearing notification always says "0 watches queued for rechecking." Non-paused watches are enqueued as expected.

Version
0.49.0

How did you install?
Docker

To Reproduce
Steps to reproduce the behavior:

  1. Create one or several watches.
  2. PAUSE these watches.
  3. Assign a tag to these watches.
  4. Select the tag in the tag list.
  5. Scroll down to the button 'Recheck all in ¨_tag-name_"'.
  6. Press it.
  7. Observe that none of the paused watches were enqueued.
  8. Observe that notification informs: "0 watches queued for rechecking."

Expected behavior

  1. All watches with the tag should be enqueued, including paused.
  2. The notification should inform: "N watches queued for rechecking."
@dgtlmoon
Copy link
Owner

That's correct, paused watches shouldnt be re-queued. ?

@birukoff
Copy link
Author

birukoff commented Jan 27, 2025

Hm, why? By pressing the button the user explicitly asked to re-check them. And, as button says, "all watches in tag-name". I would argue the expected behaviour is to check all of them as a response to a manual action.

(I am the example of such a confused user. I even filled the first report because had no clue that the button only applies to some watches)

@birukoff
Copy link
Author

The way I see it, there are several way to deal with the issue:

  1. Remove the button. It is functionally redundant considering that one can select all tag's watches and re-check them by clicking "Recheck" button above the table.
  2. Change the wording of the button.
  3. Change the behaviour of the button.

@dgtlmoon
Copy link
Owner

dgtlmoon commented Jan 29, 2025

I remember a little while ago someone filed an issue for the exact opposite, that paused watches were being queued..

I dont want to change that, sorry

Remove the button. It is functionally redundant considering that one can select all tag's watches and re-check them by clicking "Recheck" button above the table.

No, people could have many watches across different "paged" lists, like 50 per page but you have 300 watches

Change the wording of the button.

To what exactly?

Change the behaviour of the button.

No sorry, i think it does what it does

@birukoff
Copy link
Author

Change the wording of the button.

To what exactly?

Recheck unpaused watches in $tag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants