-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken RSS after 0.49.5 (or greater) update #3053
Comments
using |
I came here as well after my miniflux reader reports tens of issues with all changedetection feeds I had configured for a long time, which I could fix by updating all feed URLs to add a |
yeah strange, it's redirecting to
|
@x0tester0x what has this todo with the RSS? |
@dgtlmoon I open the link to the diff page from the RSS feed... |
so the rss feed works then... ? |
Hi, W3C returns: Now, even with the new URLs that contain
So I'm curious what you have on your side fro this validation service with old and new URLs. |
Since no one here has bothered to give me any actual URLs they are following, I cannot verify any further information despite the fact that i've asked you all to give some actual URLs and its even in the issue template that you need todo so And yet i'm demanded "tell me what you changed! i want an explaination! " this is massively unproductive I'm very sure the only change here is that the URL ended in heres the fix |
Since the initial report doesnt even include the RSS output!!!!! I mean guys come on, how am i meant to solve this and be "summoned" by your questions? its so unfair |
@x0tester0x thank you so much, i found that bug (also added a test) |
I would dare to share but that would mean I share my instance URL (which I want to keep private) and my token (which could give privileges to everyone for accessing my private data), right? The fact W3C validation service also doesn't recognize such URLs neither make me feel that the RSS readers could be right to claim the problem is not on their side, yet I'm happy to open a ticket on Miniflux and other RSS readers at need (RSS-Bridge also fails on the new URLs). |
Since you seem to know the answer, I'm happy to get a PR from you to fix it |
Let me repeat I'm very sure the only change here is that the URL ended in / and your feed reader cant deal with that heres the fix |
Thanks for the proposal! |
I'll send you an example URL in PM (email). |
Hi everyone, I can only reply now but I see that the conversation has continued. @dgtlmoon I could not include RSS output, but if seems that feeds had some broken character inside. If it can help, I had this problem only with feeds with cookie bot popup. I deactivated all of them and solved. For instance, I had that problem with FreshRss reader that is little bit more "sensitive" to those kind of issues, but eg. with Thunderbird Rss reader everything worked fine. Take a look of this one: This [#IABV_TITLE#] seems to broke RSS from from my side. |
FreshRss hmm i will try it |
third time... fourth time? I need to see actual rss feed information I cannot help without seeing actual RSS information |
please try 0.49.8 |
I'll assume fixed |
and another thing, no one gave any log output from their CDIO, so i dont even know if you guys were hitting some obscure error inside of cdio this really is such a badly reported issue |
Hey, I agree with you on the lack of proper log report for some of the issues mentioned here. Now in my case the problem was not changedetection unable to do some of its core tasks and there was nothing like an error in the log except if I try bad URLs like the ones this change has turned into deprecated URLs. |
@SansGuidon once again, please try 0.49.8 did it solve your problem? |
@dgtlmoon I don't know yet, I use Changedetection as packaged by Cloudron and the update is not available yet to me but it should be soon (today hopefully). |
I'll drop a newer version soon, it has a couple of extra features for RSS people |
I tried the new Verison and it works I can see again the diff page. |
@dgtlmoon I confirm the change fixes the URLs, so I'm removing the |
So the problem wasnt broken RSS, the problem was the RSS feeder not following the redirect.. as i said it was likely the problem then i think |
OR the RSS reader started reading a 404 page like /rss/ or something and thinking it was RSS, but as no one really gave me enough information i couldnt see the actual RSS "output" |
I've emailed you a RSS link with at least 6 RSS Validation services (including W3C) that failed on the RSS link provided by CDIO which confirm the generated RSS was invalid. So now we can of course blame it on W3C and RSS Bridge and Miniflux and other so they change their way of doing and adapt to CDIO, or we can assume the problem was with CDIO. |
@SansGuidon "which confirm the generated RSS was invalid." except no one has yet shown me what the RSS reader is "seeing" exactly, the reader could be looking at the login page for all i know And what about the original poster? @50LUD4 does the latest version work for you? hello? |
I’m concerned about the repeated tone of rant and emphasis on RSS reader responsibility. While some readers might interpret things differently, many validation tools maintainers could not want to adapt just for compatibility with CDIO urls. I’m happy to help troubleshoot this. I'll set up a version v49.7 instance of CDIO alongside my current setup for us to work on a solution together. I'll keep you posted but I might need to dig deeper in some of those RSS readers before I ping back. Wish me luck. |
So I've just create an instance of CDIO with the default watches on v49.7 and started with Miniflux and RSS-Bridge to debug mode. TLDRCDIO is 302 redirecting rss readers to the login. A feed aggregator wants raw XML—not an auth page. I hope those 90 min debugging won't be wasted ⏲. Test 1 : MinifluxError and logs (⚠ Redacted) of Miniflux when trying to subscribe some RSS feed with User facing error message:
App LogsMar 27 11:09:32 level=DEBUG msg="Making outgoing request" request.method=GET request.url="https://cdio.domain.com/rss?token=<REDACTED>" request.headers="map[Accept:[application/xml, application/atom+xml, application/rss+xml, application/rdf+xml, application/feed+json, text/html, */*;q=0.9] Accept-Encoding:[br, gzip] Connection:[close] User-Agent:[Mozilla/5.0 (compatible; Miniflux/2.2.6; +https://miniflux.app)]]" request.without_redirects=false request.with_proxy=false request.proxy_url="" request.ignore_tls_errors=false request.disable_http2=false
Mar 27 11:09:32 level=DEBUG msg="Request response" effective_url="https://cdio.domain.com/login?next=/" content_length=4638 content_encoding=br content_type="text/html; charset=utf-8"
Mar 27 11:09:32 level=DEBUG msg="Try to detect feeds from YouTube channel page" website_url="https://cdio.domain.com/rss?token=<REDACTED>"
Mar 27 11:09:32 level=DEBUG msg="This website is not a YouTube page, the regex doesn't match" website_url="https://cdio.domain.com/rss?token=<REDACTED>"
Mar 27 11:09:32 level=DEBUG msg="Try to detect feeds from YouTube playlist page" website_url="https://cdio.domain.com/rss?token=<REDACTED>"
Mar 27 11:09:32 level=DEBUG msg="This website is not a YouTube page, the regex doesn't match" website_url="https://cdio.domain.com/rss?token=<REDACTED>"
Mar 27 11:09:32 level=DEBUG msg="Try to detect feeds from HTML meta tags" website_url="https://cdio.domain.com/rss?token=<REDACTED>" content_type="text/html; charset=utf-8"
Mar 27 11:09:32 level=DEBUG msg="Try to detect feeds with RSS-Bridge" website_url="https://cdio.domain.com/rss?token=<REDACTED>"
Mar 27 11:09:32 level=DEBUG msg="Trying to detect feeds using RSS-Bridge" website_url="https://cdio.domain.com/rss?token=<REDACTED>" rssbridge_url=https://rssbridge.domain.com
Mar 27 11:09:32 level=DEBUG msg="Detecting RSS bridges" url="https://rssbridge.domain.com?action=findfeed&format=atom&url=https%3A%2F%2Fcdio.domain.com%2Frss%3Ftoken%3D<REDACTED>"
Mar 27 11:09:32 level=DEBUG msg="Incoming request" client_ip=<REDACTED> request.method=POST request.uri=/subscribe request.protocol=HTTP/1.1 request.execution_time=131.681005ms
Mar 27 11:09:32 level=DEBUG msg="User session found" url=/manifest.json user_id=1 user_session_id=43 And as we see, Miniflux has attempted to use RSS-bridge to resolve the RSS feed, so I'm adding also the RSS-Bridge log for that attempt: RSS-Bridge logMar 27 11:15:44 172.18.17.158 - - [27/Mar/2025:10:15:44 +0000] "GET /?action=findfeed&format=atom&url=https%3A%2F%2Fcdio.domain.com%2Frss%3Ftoken%3D<REDACTED> HTTP/1.1" 401 703 "-" "Go-http-client/2.0" Test 2: RSS-BridgeUser facing error message:
App LogsMar 27 11:22:51 <REDACTED> - admin [27/Mar/2025:10:22:51 +0000] "GET /?action=display&bridge=FilterBridge&url=https%3A%2F%2Fcdio.domain.com%2Frss%3Ftag%3Dcf810e1d-1b9a-4db7-a78d-80f2cef8a35d%26token%3D<REDACTED>&name=&filter=&filter_type=permit&target_title=on&length_limit=-1&format=Html HTTP/1.1" 304 - "-" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/134.0.0.0 Safari/537.36"
Ok we don't learn much here. Test 3 : TinyTiny RSSUser facing error message
User facing error in debug mode (f D)
We notice the redirection to the login page. At this point, I'm yet to try another RSS reader, FreshRSS this time. Test 4: FreshRSSuser error message
App error log
FreshRSS complains about the feed and points me to the W3C Feed validation service which says the feed is invalid as well: Other RSS validation servicesOn
On
|
Correct, please try The code for generating the actual RSS feed has not changed (other than adding a filter to catch anything really extreme that breaks the UTF-8 handling). so 0.49.9 works for you? |
thanks for the info! as soon as it's made available to my Cloudron instance (I guess Cloudron team has to fix this renovate-bot pipeline first https://git.cloudron.io/packages/changedetection-app/-/pipelines/14010), I'll come back to you. |
My CDIO instance was updated yesterday. It still works as before yes afaik. Anything specific I should test beyond the RSS feeds? |
On two different self-hosted instances, RSS it broken after 0.49.5 (or greater) update.
FreshRss Rss reader says:
1st instance: "the status code is
200
and content-type istext/html; charset=utf-8
"2nd instance: "is invalid XML, likely due to invalid characters. XML error: Attribute without value at line xx, column xx"
The text was updated successfully, but these errors were encountered: