Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Window with minimizable: false still shows activatable "Minimize" menu item #43130

Open
3 tasks done
Cloudkkk opened this issue Jul 31, 2024 · 5 comments · May be fixed by #46279
Open
3 tasks done

[Bug]: Window with minimizable: false still shows activatable "Minimize" menu item #43130

Cloudkkk opened this issue Jul 31, 2024 · 5 comments · May be fixed by #46279
Labels

Comments

@Cloudkkk
Copy link

Cloudkkk commented Jul 31, 2024

Preflight Checklist

Electron Version

30.2.0

What operating system(s) are you using?

macOS

Operating System Version

MacOS 13.5.1

What arch are you using?

arm64 (including Apple Silicon)

Last Known Working Electron version

No response

Expected Behavior

image

Minimize menu item is disabled

Actual Behavior

image

Minimize menu item is interactable, but does not cause any change in the window

Testcase Gist URL

https://gist.github.com/Cloudkkk/34443bc82dcfd92b570a21cacf183df8

Additional Information

No response

@Cloudkkk
Copy link
Author

It is my code about the window options
image

@codebytere codebytere added the blocked/need-repro Needs a test case to reproduce the bug label Jul 31, 2024
@electron-issue-triage
Copy link

Hello @Cloudkkk. Thanks for reporting this and helping to make Electron better!

Would it be possible for you to make a standalone testcase with only the code necessary to reproduce the issue? For example, Electron Fiddle is a great tool for making small test cases and makes it easy to publish your test case to a gist that Electron maintainers can use.

Stand-alone test cases make fixing issues go more smoothly: it ensure everyone's looking at the same issue, it removes all unnecessary variables from the equation, and it can also provide the basis for automated regression tests.

Now adding the blocked/need-repro Needs a test case to reproduce the bug label for this reason. After you make a test case, please link to it in a followup comment. This issue will be closed in 10 days if the above is not addressed.

@codebytere
Copy link
Member

Screenshot 2024-07-31 at 3 24 10 PM

couldn't reproduce this - we'll need a sample to proceed!

@Cloudkkk
Copy link
Author

Cloudkkk commented Aug 1, 2024

https://gist.github.com/Cloudkkk/34443bc82dcfd92b570a21cacf183df8

thanks for your reply, please check the Menu,you can see the minisize button in window tab.
it can still be clicked, is it a feature?🤔
@codebytere

@electron-issue-triage electron-issue-triage bot removed the blocked/need-repro Needs a test case to reproduce the bug label Aug 1, 2024
@clavin clavin changed the title [Bug]: "window" tab in Menu,the Minimize button can still be clicked for windows those have minimized disabled [Bug]: Window with minimizable: false still shows activatable "Minimize" menu item Aug 3, 2024
@clavin
Copy link
Member

clavin commented Aug 3, 2024

Thanks for the example code! 👍 I updated the title and issue text, I hope you don't mind.

I was able to verify this occurs on Electron v31.2.0 on macOS. Specifically, the erroneous behavior is that a window that is not minimizable still shows the "Minimize" menu item as if it were able to be interacted with, when it should be disabled.

I'm assuming this bug is likely macOS-only, but I did not test on other platforms.

@clavin clavin added platform/macOS status/confirmed A maintainer reproduced the bug or agreed with the feature 3-1-x 31-x-y and removed 3-1-x labels Aug 3, 2024
@github-project-automation github-project-automation bot moved this to 👀 Unsorted Items in 31-x-y Aug 3, 2024
@clavin clavin added the 32-x-y label Aug 3, 2024
@github-project-automation github-project-automation bot moved this to 👀 Unsorted Items in 32-x-y Aug 3, 2024
@mlaurencin mlaurencin linked a pull request Mar 25, 2025 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: 👀 Unsorted Items
Status: 👍 Does Not Block Stable
Development

Successfully merging a pull request may close this issue.

4 participants