-
Notifications
You must be signed in to change notification settings - Fork 15.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Window with minimizable: false
still shows activatable "Minimize" menu item
#43130
Comments
Hello @Cloudkkk. Thanks for reporting this and helping to make Electron better! Would it be possible for you to make a standalone testcase with only the code necessary to reproduce the issue? For example, Electron Fiddle is a great tool for making small test cases and makes it easy to publish your test case to a gist that Electron maintainers can use. Stand-alone test cases make fixing issues go more smoothly: it ensure everyone's looking at the same issue, it removes all unnecessary variables from the equation, and it can also provide the basis for automated regression tests. Now adding the
blocked/need-repro
|
https://gist.github.com/Cloudkkk/34443bc82dcfd92b570a21cacf183df8 thanks for your reply, please check the Menu,you can see the minisize button in window tab. |
minimizable: false
still shows activatable "Minimize" menu item
Thanks for the example code! 👍 I updated the title and issue text, I hope you don't mind. I was able to verify this occurs on Electron v31.2.0 on macOS. Specifically, the erroneous behavior is that a window that is not minimizable still shows the "Minimize" menu item as if it were able to be interacted with, when it should be disabled. I'm assuming this bug is likely macOS-only, but I did not test on other platforms. |
Preflight Checklist
Electron Version
30.2.0
What operating system(s) are you using?
macOS
Operating System Version
MacOS 13.5.1
What arch are you using?
arm64 (including Apple Silicon)
Last Known Working Electron version
No response
Expected Behavior
Minimize menu item is disabled
Actual Behavior
Minimize menu item is interactable, but does not cause any change in the window
Testcase Gist URL
https://gist.github.com/Cloudkkk/34443bc82dcfd92b570a21cacf183df8
Additional Information
No response
The text was updated successfully, but these errors were encountered: