Skip to content

Unable to consistently add bookmarks #177

Open
@ItsMeBrianD

Description

@ItsMeBrianD

Describe the bug
If you wait too long, or attempt to add multiple bookmarks, the URL field does not respond to a link being input

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Home page'
  2. Click on 'Add bookmark'
  3. Wait 5 seconds
  4. Paste a link

Expected behavior
Metadata for the pasted / inputted URL

Screenshots

Desktop (please complete the following information):

  • OS: MacOS 15.3
  • Browser: Arc & Safari
  • Version: Arc 133.0.6943.127 (arm64), Safari 18.3

Additional context
I did a bit of digging and I think the issue has to do with the abort signal here: https://github.com/goniszewski/grimoire/blob/main/src/lib/components/AddBookmarkForm/AddBookmarkForm.svelte#L191

When I add a breakpoint in Safari to the URL input for on:input, I see that e.aborted=true within the internals of the debounce functionality. I think this component is essentially disabling itself after 5 seconds.

Similarly, because the AddBookmarkForm is being processed on page mount (rather than on modal open), I believe you are essentially unable to add a new bookmark if more than 5 seconds have passed since you opened the page.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions