Skip to content

Fix reorg threshold #5941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 14, 2025
Merged

Fix reorg threshold #5941

merged 3 commits into from
Apr 14, 2025

Conversation

zorancv
Copy link
Contributor

@zorancv zorancv commented Apr 11, 2025

Addressing the review comments from #5804 and squashed previous commits to one verified commit.

@zorancv zorancv force-pushed the zoran/fix-reorg-threshold-bug2 branch from 3c14f38 to ddc9eac Compare April 11, 2025 12:35
@zorancv zorancv marked this pull request as ready for review April 11, 2025 13:44
@zorancv zorancv requested a review from lutter April 11, 2025 13:45
Copy link
Collaborator

@lutter lutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like how this turned out

@@ -17,6 +18,7 @@ use crate::{

lazy_static! {
pub static ref ENV_VARS: EnvVars = EnvVars::from_env().unwrap();
pub static ref TEST_WITH_NO_REORG: Mutex<bool> = Mutex::new(false);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is minor, but I think we could also compile this out with #[cfg(not(debug_assertions))]

@zorancv zorancv force-pushed the zoran/fix-reorg-threshold-bug2 branch from a4d8bc9 to 1b1b6a3 Compare April 14, 2025 08:58
@zorancv zorancv force-pushed the zoran/fix-reorg-threshold-bug2 branch from 1b1b6a3 to 1fd774a Compare April 14, 2025 09:01
@zorancv zorancv merged commit c051672 into master Apr 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants