Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #10640: the interface fails to be queried,/v1/graphql #10705

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

david-ourlegup
Copy link

The schema registry notification color hook has been updated to improve performance. A check was added to skip API calls if running in CE mode or if the schema registry host is not configured. This change also includes a modification that skips the query completely when the schema registry is unavailable, and returns a loading state instead. These enhancements aim to optimize resource usage and provide better user experience.

The schema registry notification color hook has been updated to improve performance. A check was added to skip API calls if running in CE mode or if the schema registry host is not configured. This change also includes a modification that skips the query completely when the schema registry is unavailable, and returns a loading state instead. These enhancements aim to optimize resource usage and provide better user experience.
@Varun-Choudhary
Copy link
Contributor

Thanks @david-ourlegup for submitting this PR to improve the schema registry notification color hook! These optimizations look very useful - particularly skipping API calls in CE mode and when the schema registry host isn't configured, and the improved handling when the registry is unavailable.
We'll test these changes and review the code. If everything looks good, we'll merge this and include it in our next release.
Appreciate your contribution to improving performance and UX!

@Varun-Choudhary
Copy link
Contributor

Thanks again @david-ourlegup for your PR contribution. To help me better understand the changes:

Could you please elaborate on what specific problem you encountered that led to these optimizations? I'd like to understand the exact issue you're trying to solve.
If possible, could you share a screen recording that demonstrates the issue and how your changes address it? This would be very helpful for my review process.

Your insights will help ensure we properly test and validate the improvements before merging. Looking forward to your response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants