Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling Reasoning Summary as an Env Option #1720

Open
SulRash opened this issue Feb 17, 2025 · 5 comments
Open

Disabling Reasoning Summary as an Env Option #1720

SulRash opened this issue Feb 17, 2025 · 5 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers models This issue is related to model performance/reliability

Comments

@SulRash
Copy link

SulRash commented Feb 17, 2025

Describe your feature request

Hello, I just thought that having the ability to disable this feature would be nice considering a lot of people might have rate limits.

Implementation idea

Just an env variable that disables the function in TS.

@SulRash SulRash added the enhancement New feature or request label Feb 17, 2025
@nsarrazin
Copy link
Collaborator

I think that's a good idea, I'll happily review a PR for this!

@nsarrazin nsarrazin added good first issue Good for newcomers models This issue is related to model performance/reliability labels Feb 17, 2025
@dhruv1710
Copy link

Hey @nsarrazin,

I would like to contribute to it and had a few questions

  1. In the readme.md it is written that summarization can be enabled for the QwQ model which means it's optional.
  2. My approach would be to check if reasoning_summary env variable is true and based on that call the ‎generateSummaryOfReasoning‎

@nsarrazin
Copy link
Collaborator

Hi! I think the easiest solution is to add a check for the env variable here indeed :) I'm assigning you let me know if you need any help

@dhruv1710
Copy link

Sorry for the delay but I've opened a pull request on this issue

@dhruv1710
Copy link

Any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers models This issue is related to model performance/reliability
Projects
None yet
Development

No branches or pull requests

3 participants