Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 Remove .env.development file #953

Merged
merged 2 commits into from
Mar 21, 2025
Merged

🔧 Remove .env.development file #953

merged 2 commits into from
Mar 21, 2025

Conversation

junkisai
Copy link
Member

@junkisai junkisai commented Mar 21, 2025 •
edited
Loading

Issue

  • resolve:

Why is this change needed?

The environment variables that were managed in .env.development are now set when running pnpm vercel:env-pull, so the file is no longer needed.

What would you like reviewers to focus on?

Testing Verification

  • pnpm vercel:env-pull
  • set TRIGGER_SECRET_KEY, OPENAI_API_KEY
  • pnpm -F app trigger:dev, pnpm -F app dev

What was done

🤖 Generated by PR Agent at c89f2c2

  • Removed the .env.development file as it is no longer needed.
  • Added a new .env.template file for environment variable configuration.
  • Streamlined environment variable management using pnpm vercel:env-pull.

Detailed Changes

Relevant files
Configuration changes
.env.template
Added `.env.template` for environment variables                   

.env.template

  • Added a new .env.template file.
  • Provides placeholders for environment variable configuration.
  • Facilitates standardized environment variable management.
    		• +20/-0   
    .env.development
    Removed `.env.development` file                                                   

    frontend/apps/app/.env.development

  • Removed the .env.development file.
  • Environment variables are now managed externally.
    		• +0/-5     

    Additional Notes

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
    •

    @changeset-bot changeset-bot
    Copy link

    changeset-bot bot commented Mar 21, 2025

    ⚠️ No Changeset found

    Latest commit: c89f2c2

    Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

    This PR includes no changesets

    When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

    Click here to learn what changesets are, and how to add one.

    Click here if you're a maintainer who wants to add a changeset to this PR

    @vercel Vercel
    Copy link

    vercel bot commented Mar 21, 2025 •
    edited
    Loading

    The latest updates on your projects. Learn more about Vercel for Git ↗︎

    Name Status Preview Comments Updated (UTC)
    liam-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2025 8:06am
    liam-erd-sample ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2025 8:06am
    4 Skipped Deployments
    Name Status Preview Comments Updated (UTC)
    liam-docs ⬜️ Ignored (Inspect) Visit Preview Mar 21, 2025 8:06am
    test-liam-app ⬜️ Ignored (Inspect) Mar 21, 2025 8:06am
    test-liam-docs ⬜️ Ignored (Inspect) Mar 21, 2025 8:06am
    test-liam-erd-sample ⬜️ Ignored (Inspect) Mar 21, 2025 8:06am

    @supabase Supabase
    Copy link

    supabase bot commented Mar 21, 2025 •
    edited
    Loading

    Updates to Preview Branch (clean/delete-env-development) ↗︎

    Deployments Status Updated
    Database ✅ Fri, 21 Mar 2025 07:53:11 UTC
    Services ✅ Fri, 21 Mar 2025 07:53:11 UTC
    APIs ✅ Fri, 21 Mar 2025 07:53:11 UTC

    Tasks are run on every commit but only new migration files are pushed.
    Close and reopen this PR if you want to apply changes from existing seed or migration files.

    Tasks Status Updated
    Configurations ✅ Fri, 21 Mar 2025 07:53:30 UTC
    Migrations ✅ Fri, 21 Mar 2025 07:53:33 UTC
    Seeding ✅ Fri, 21 Mar 2025 07:53:33 UTC
    Edge Functions ✅ Fri, 21 Mar 2025 07:53:33 UTC

    View logs for this Workflow Run ↗︎.
    Learn more about Supabase for Git ↗︎.

    @junkisai junkisai marked this pull request as ready for review March 21, 2025 07:55
    @junkisai junkisai requested a review from a team as a code owner March 21, 2025 07:55
    @junkisai junkisai requested review from hoshinotsuyoshi, FunamaYukina, MH4GF, NoritakaIkeda and sasamuku and removed request for a team March 21, 2025 07:55
    @qodo-merge-pro-for-open-source Qodo Merge Pro for Open Source
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Sensitive Data

    The .env.template file contains empty placeholders for sensitive environment variables. Ensure that no actual secrets or API keys were accidentally committed in this template file.

     
    FLAGS_SECRET=""
GITHUB_APP_ID=""
GITHUB_CLIENT_ID=""
GITHUB_CLIENT_SECRET=""
GITHUB_PRIVATE_KEY=""
MIGRATION_ENABLED=""
NEXT_PUBLIC_BASE_URL=""
NEXT_PUBLIC_ENV_NAME=""
NEXT_PUBLIC_GITHUB_APP_URL=""
NEXT_PUBLIC_SUPABASE_ANON_KEY=""
NEXT_PUBLIC_SUPABASE_URL=""
OPENAI_API_KEY=""
POSTGRES_URL=""
POSTGRES_URL_NON_POOLING=""
SENTRY_AUTH_TOKEN=""
SENTRY_DSN=""
SENTRY_ORG=""
SENTRY_PROJECT=""
TRIGGER_PROJECT_ID=""
TRIGGER_SECRET_KEY=""

    @qodo-merge-pro-for-open-source Qodo Merge Pro for Open Source
    Copy link
    Contributor

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    Security
    Use descriptive placeholders

    Avoid using empty strings for sensitive environment variables in template files.
    Use placeholder text that clearly indicates what should be filled in, to prevent
    accidental deployment with empty credentials.

    .env.template [10]

    -NEXT_PUBLIC_SUPABASE_ANON_KEY=""
+NEXT_PUBLIC_SUPABASE_ANON_KEY="your-supabase-anon-key-here"
    • Apply this suggestion
    Suggestion importance[1-10]: 5

    __

    Why: Using descriptive placeholders instead of empty strings is a good practice for template files as it provides clearer guidance to developers. This reduces the risk of deploying with empty credentials, though it's a moderate rather than critical security improvement.

    		Low
    • More

    NoritakaIkeda
    NoritakaIkeda approved these changes Mar 21, 2025
    View reviewed changes
    Copy link
    Member

    @NoritakaIkeda NoritakaIkeda left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM!

    .env.template
    Comment on lines +1 to +20
    FLAGS_SECRET=""
    GITHUB_APP_ID=""
    GITHUB_CLIENT_ID=""
    GITHUB_CLIENT_SECRET=""
    GITHUB_PRIVATE_KEY=""
    MIGRATION_ENABLED=""
    NEXT_PUBLIC_BASE_URL=""
    NEXT_PUBLIC_ENV_NAME=""
    NEXT_PUBLIC_GITHUB_APP_URL=""
    NEXT_PUBLIC_SUPABASE_ANON_KEY=""
    NEXT_PUBLIC_SUPABASE_URL=""
    OPENAI_API_KEY=""
    POSTGRES_URL=""
    POSTGRES_URL_NON_POOLING=""
    SENTRY_AUTH_TOKEN=""
    SENTRY_DSN=""
    SENTRY_ORG=""
    SENTRY_PROJECT=""
    TRIGGER_PROJECT_ID=""
    TRIGGER_SECRET_KEY=""
    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    📝
    The additions seem to be just right.

    @NoritakaIkeda NoritakaIkeda added this pull request to the merge queue Mar 21, 2025
    MH4GF
    MH4GF approved these changes Mar 21, 2025
    View reviewed changes
    Copy link
    Member

    @MH4GF MH4GF left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    👍🏻

    Could you edit CONTRIBUTING.md, if necessary? Good to be handled in a separate PR.
    https://github.com/liam-hq/liam/blob/e87862695b8c0cf097cfa35d254a6331d16a5ef4/CONTRIBUTING.md

    Merged via the queue into main with commit dcf2b3a Mar 21, 2025
    20 checks passed
    @NoritakaIkeda NoritakaIkeda deleted the clean/delete-env-development branch March 21, 2025 08:04
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @MH4GF MH4GF

    @NoritakaIkeda NoritakaIkeda

    @hoshinotsuyoshi hoshinotsuyoshi

    @FunamaYukina FunamaYukina

    @sasamuku sasamuku

    Assignees

    @junkisai junkisai

    Labels
    Review effort 1/5
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @junkisai @MH4GF @NoritakaIkeda