Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Support direction TD in Subgraphs #6415

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

BambioGaming
Copy link

📑 Summary

Fixes a parsing issue where using direction TD inside a subgraph would throw a parse error or be ignored.
This change ensures that subgraph-local directions (TD, BT, RL, LR, etc.) are fully supported in the grammar and properly rendered.

Resolves #6338

📏 Design Decisions

  • Updated the flow.jison grammar to allow direction TD and other directions inside subgraphs.

image

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Mar 25, 2025

⚠️ No Changeset found

Latest commit: 73db8d8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Type: Bug / Error Something isn't working or is incorrect label Mar 25, 2025
Copy link

netlify bot commented Mar 25, 2025

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 73db8d8
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/67e2c29fce2a740008391996
😎 Deploy Preview https://deploy-preview-6415--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Mar 25, 2025

Open in Stackblitz

npm i https://pkg.pr.new/mermaid-js/mermaid@6415
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6415
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6415
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6415

commit: 73db8d8

Copy link

argos-ci bot commented Mar 25, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Mar 25, 2025, 2:58 PM

Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 3.86%. Comparing base (936d107) to head (73db8d8).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6415   +/-   ##
=======================================
  Coverage     3.86%   3.86%           
=======================================
  Files          412     411    -1     
  Lines        43189   43178   -11     
  Branches       664     664           
=======================================
  Hits          1670    1670           
+ Misses       41519   41508   -11     
Flag Coverage Δ
unit 3.86% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Direction TD Inside subgraph Causes Parsing Error
1 participant