-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Support direction TD
in Subgraphs
#6415
base: develop
Are you sure you want to change the base?
Fix: Support direction TD
in Subgraphs
#6415
Conversation
|
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
commit: |
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
…ambioGaming/mermaid into bug/6338_subgraph-direction-td
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6415 +/- ##
=======================================
Coverage 3.86% 3.86%
=======================================
Files 412 411 -1
Lines 43189 43178 -11
Branches 664 664
=======================================
Hits 1670 1670
+ Misses 41519 41508 -11
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
📑 Summary
Fixes a parsing issue where using
direction TD
inside a subgraph would throw a parse error or be ignored.This change ensures that subgraph-local directions (
TD
,BT
,RL
,LR
, etc.) are fully supported in the grammar and properly rendered.Resolves #6338
📏 Design Decisions
flow.jison
grammar to allowdirection TD
and other directions inside subgraphs.📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.