Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: separate lint, run tests on code changes #2679

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

panekj
Copy link

@panekj panekj commented Feb 22, 2025

Split lint into separate job and limit Go tests to run only for changes that affect the code
Add gitattributes and renormalize files

@panekj panekj requested a review from a team as a code owner February 22, 2025 14:34
Copy link
Contributor

github-actions bot commented Feb 22, 2025

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 3 0 0.01s
✅ REPOSITORY gitleaks yes no 3.3s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 9.74s
✅ REPOSITORY secretlint yes no 1.28s
✅ REPOSITORY trivy-sbom yes no 0.74s
✅ REPOSITORY trufflehog yes no 5.19s
⚠️ YAML prettier 2 1 0.28s
✅ YAML v8r 2 0 2.37s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@mergify mergify bot added the needs-work Extra attention is needed label Feb 22, 2025
Copy link

codecov bot commented Feb 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.29%. Comparing base (5a80a04) to head (b395fbb).
Report is 176 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2679       +/-   ##
===========================================
+ Coverage   61.56%   74.29%   +12.72%     
===========================================
  Files          53       72       +19     
  Lines        9002    11051     +2049     
===========================================
+ Hits         5542     8210     +2668     
+ Misses       3020     2208      -812     
- Partials      440      633      +193     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChristopherHX
Copy link
Contributor

if ci is skipped due to such a filter then is the status check missing (not skipped, just not present) => we might need changes to mergify / permissions...

Projects like gitea, use an action that emulates this github actions paths without such problems......
Not trivial

@panekj panekj force-pushed the panekj/ci/improve-jobs branch from 02ea975 to 31a1a4b Compare February 22, 2025 15:17
@panekj panekj force-pushed the panekj/ci/improve-jobs branch from 31a1a4b to b395fbb Compare February 22, 2025 15:24
@mergify mergify bot removed the needs-work Extra attention is needed label Feb 22, 2025
@mergify mergify bot requested a review from a team February 22, 2025 15:41
@cplee
Copy link
Contributor

cplee commented Feb 25, 2025

@panekj - can you add some notes to the description to document the intention of this PR? Also - what are your thoughts about the comment @ChristopherHX made regarding test-linux being a required check to merge?

@panekj
Copy link
Author

panekj commented Feb 25, 2025

what are your thoughts about the comment @ChristopherHX made regarding test-linux being a required check to merge?

It's possible that it might break and probably should be fixed. Other than that, I'm not touching Mergify since I don't know it and have no intention to figure out how it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants