-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: separate lint, run tests on code changes #2679
base: master
Are you sure you want to change the base?
Conversation
🦙 MegaLinter status:
|
Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
---|---|---|---|---|---|
✅ EDITORCONFIG | editorconfig-checker | 3 | 0 | 0.01s | |
✅ REPOSITORY | gitleaks | yes | no | 3.3s | |
✅ REPOSITORY | git_diff | yes | no | 0.01s | |
✅ REPOSITORY | grype | yes | no | 9.74s | |
✅ REPOSITORY | secretlint | yes | no | 1.28s | |
✅ REPOSITORY | trivy-sbom | yes | no | 0.74s | |
✅ REPOSITORY | trufflehog | yes | no | 5.19s | |
prettier | 2 | 1 | 0.28s | ||
✅ YAML | v8r | 2 | 0 | 2.37s |
See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true
in mega-linter.yml to validate all sources, not only the diff
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2679 +/- ##
===========================================
+ Coverage 61.56% 74.29% +12.72%
===========================================
Files 53 72 +19
Lines 9002 11051 +2049
===========================================
+ Hits 5542 8210 +2668
+ Misses 3020 2208 -812
- Partials 440 633 +193 ☔ View full report in Codecov by Sentry. |
if ci is skipped due to such a filter then is the status check missing (not skipped, just not present) => we might need changes to mergify / permissions... Projects like gitea, use an action that emulates this github actions paths without such problems...... |
02ea975
to
31a1a4b
Compare
31a1a4b
to
b395fbb
Compare
@panekj - can you add some notes to the description to document the intention of this PR? Also - what are your thoughts about the comment @ChristopherHX made regarding |
It's possible that it might break and probably should be fixed. Other than that, I'm not touching Mergify since I don't know it and have no intention to figure out how it works. |
Split lint into separate job and limit Go tests to run only for changes that affect the code
Add gitattributes and renormalize files