Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zsh: update zsh initContent example to use lib.literalExpression #6637

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

Emin017
Copy link
Contributor

@Emin017 Emin017 commented Mar 16, 2025

Description

Fix zsh initContent option example display error, see previous discussion: #6479 (comment)

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all
    or nix build --reference-lock-file flake.lock ./tests#test-all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

@teto

@github-actions github-actions bot added the shell label Mar 16, 2025
Copy link
Collaborator

@teto teto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep that fixed it ty. I can't merge with CI breakage, which is due to something else sadly.

@Emin017
Copy link
Contributor Author

Emin017 commented Mar 17, 2025

It seems to be blocked by: NixOS/nixpkgs#345659

@khaneliman
Copy link
Collaborator

Sorry, I'll try scrubbing some more packages on darwin to prevent random breakages like this for CI...

@Emin017
Copy link
Contributor Author

Emin017 commented Mar 17, 2025

I opened: NixOS/nixpkgs#390602 to fix jbigkit's build on darwin.

@khaneliman
Copy link
Collaborator

updated CI, you can rebase this

Update the `initContent` option example in `zsh.nix` to use
`lib.literalExpression` for correctly display in documentation.

Signed-off-by: Qiming Chu <cchuqiming@gmail.com>
@khaneliman khaneliman force-pushed the zsh-initContent-example branch from 03b9916 to 46a6d69 Compare March 17, 2025 19:57
@khaneliman khaneliman merged commit b870fb2 into nix-community:master Mar 17, 2025
3 checks passed
nfelber pushed a commit to nfelber/home-manager that referenced this pull request Mar 19, 2025
…-community#6637)

Update the `initContent` option example in `zsh.nix` to use
`lib.literalExpression` for correctly display in documentation.

Signed-off-by: Qiming Chu <cchuqiming@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants