Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add support for pnpm catalogs #1989

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AllieJonsson
Copy link
Contributor

@AllieJonsson AllieJonsson commented Mar 25, 2025

Status

READY

Description

fixes #1965
This is based on how I interpreted the pnpm catalog docs (https://pnpm.io/catalogs), I myself dont use pnpm so I dont have the complete knowledge about any undocumented behavior

Steps to Test or Reproduce

  1. Add a pnpm-workspace.yaml file in the root of the project with the following contents:
catalog:
  typescript: 5.3.3

catalogs:
  # Can be referenced through "catalog:ts4"
  ts4:
    typescript: 4.3.0

  # Can be referenced through "catalog:ts5"
  ts5:
    typescript: 5.3.3
  1. Edit package.json in /tests:
-    "typescript": "5.3.3"
+    "typescript": "catalog:"
  1. generate, notice no errors!
  2. Also try setting typescript version to "catalog:default", "catalog:ts4" or "catalog:ts5" and notice no errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pnpm catalog fails to parse version in package.json
1 participant