Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Original object not retrieved when user logs in with third party auth #7742

Open
wants to merge 52 commits into
base: alpha
Choose a base branch
from
Open

fix: Original object not retrieved when user logs in with third party auth #7742

wants to merge 52 commits into from

Conversation

Meglali20
Copy link
Contributor

New Pull Request Checklist

Issue Description

Related issue: issue#7737

Approach

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • Add security check
  • Add new Parse Error codes to Parse JS SDK
  • A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Dec 16, 2021 •
edited
Loading

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@Meglali20 Meglali20 mentioned this pull request Dec 16, 2021
Open
4 tasks
@Meglali20 Meglali20 changed the title Fail test: Original object not being retrieved when users log in with third party auth <type>: <test> Fail test: Original object not being retrieved when users log in with third party auth Dec 16, 2021
@Meglali20 Meglali20 changed the title <type>: <test> Fail test: Original object not being retrieved when users log in with third party auth Fail test: Original object not being retrieved when users log in with third party auth Dec 16, 2021
@Meglali20 Meglali20 changed the title Fail test: Original object not being retrieved when users log in with third party auth test: Original object not being retrieved when users log in with third party auth Dec 16, 2021
@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title test: Original object not being retrieved when users log in with third party auth test: original object not being retrieved when users log in with third party auth Dec 16, 2021
@mtrezza mtrezza changed the title test: original object not being retrieved when users log in with third party auth fix: original object not being retrieved when user logs in with third party auth Dec 16, 2021
@parse-community parse-community locked and limited conversation to collaborators Dec 16, 2021
@parse-community parse-community unlocked this conversation Dec 16, 2021
@mtrezza mtrezza changed the title fix: original object not being retrieved when user logs in with third party auth fix: original object not retrieved when user logs in with third party auth Dec 16, 2021
mtrezza
mtrezza reviewed Dec 19, 2021
View reviewed changes
mtrezza
mtrezza requested changes Dec 21, 2021
View reviewed changes
mtrezza
mtrezza reviewed Dec 23, 2021
View reviewed changes
mtrezza and others added 13 commits January 27, 2022 22:44
@mtrezza
Merge branch 'alpha' into aftersave-auth-user
10055d7
@mtrezza
ci: fix node engine check (parse-community#7891)
9ef1968
@dblythy
fix: return correct response when revert is used in beforeSave (parse…
f63fb2b 
…-community#7839)
@semantic-release-bot
chore(release): 5.2.1-alpha.1 [skip ci]
b3199d7 
## [5.2.1-alpha.1](parse-community/parse-server@5.2.0...5.2.1-alpha.1) (2022-03-26)

### Bug Fixes

* return correct response when revert is used in beforeSave ([parse-community#7839](parse-community#7839)) ([f63fb2b](parse-community@f63fb2b))
@dblythy
perf: reduce database operations when using the constant parameter in…
48bd512 
… Cloud Function validation (parse-community#7892)
@semantic-release-bot
chore(release): 5.2.1-alpha.2 [skip ci]
e0cca58 
## [5.2.1-alpha.2](parse-community/parse-server@5.2.1-alpha.1...5.2.1-alpha.2) (2022-03-26)

### Performance Improvements

* reduce database operations when using the constant parameter in Cloud Function validation ([parse-community#7892](parse-community#7892)) ([48bd512](parse-community@48bd512))
@github-actions
feat: add MongoDB 5.1 compatibility (parse-community#7682)
90155cf
@semantic-release-bot
chore(release): 5.3.0-alpha.1 [skip ci]
499cead 
# [5.3.0-alpha.1](parse-community/parse-server@5.2.1-alpha.2...5.3.0-alpha.1) (2022-03-27)

### Features

* add MongoDB 5.1 compatibility ([parse-community#7682](parse-community#7682)) ([90155cf](parse-community@90155cf))
@mtrezza
fix: security upgrade parse push adapter from 4.1.0 to 4.1.2 (parse-c…
ef56e98 
…ommunity#7893)
@semantic-release-bot
chore(release): 5.3.0-alpha.2 [skip ci]
119dbe0 
# [5.3.0-alpha.2](parse-community/parse-server@5.3.0-alpha.1...5.3.0-alpha.2) (2022-03-27)

### Bug Fixes

* security upgrade parse push adapter from 4.1.0 to 4.1.2 ([parse-community#7893](parse-community#7893)) ([ef56e98](parse-community@ef56e98))
@mtrezza
feat: add MongoDB 5.2 support (parse-community#7894)
6b4b358
@semantic-release-bot
chore(release): 5.3.0-alpha.3 [skip ci]
75eca2d 
# [5.3.0-alpha.3](parse-community/parse-server@5.3.0-alpha.2...5.3.0-alpha.3) (2022-03-27)

### Features

* add MongoDB 5.2 support ([parse-community#7894](parse-community#7894)) ([6b4b358](parse-community@6b4b358))
@snyk-bot
refactor: upgrade mongodb from 4.3.1 to 4.4.1 (parse-community#7906)
132a3e0
@mtrezza
Copy link
Member

mtrezza commented Apr 25, 2022

Thanks for simplifying the test, it looks good to me. Do you have a suggestion for a fix?

@Meglali20
Copy link
Contributor Author

Unfortunately, I have no idea about it since it hasn't been long since I discovered and started using parse so I am not completely familiar with it and didn't look at the code yet. There could be some workaround to avoid this issue but that would be just adding unnecessary extra data to the database. you should be updating the label of the issue so that maybe someone can take a look at it and propose a solution.

@mtrezza mtrezza force-pushed the alpha branch 2 times, most recently from 59215e6 to e6d7d8f Compare May 1, 2022 02:29
@Meglali20
Copy link
Contributor Author

@mtrezza any update?

@mtrezza
Copy link
Member

mtrezza commented Jun 6, 2022 •
edited
Loading

@parse-community/server anyone has a suggestion for a fix? The failing test here already demos the issue.

@dblythy
Copy link
Member

dblythy commented Jun 6, 2022

I would assume the issue is happening somewhere around here

parse-server/src/RestWrite.js

Line 1604 in c1e808f

RestWrite.prototype.buildParseObjects = function () {

@mtrezza
Copy link
Member

mtrezza commented Jun 6, 2022

@Meglali20 Would you want to rebase this PR on alpha and resolve the conflicts?

@Meglali20
Copy link
Contributor Author

@mtrezza you mean if I could fix it? I didn't have time yet to look at the parse server code, so I don't think I could fix it at the moment, If you could provide me with some information on how the process works I would maybe try to figure it out.

@mtrezza
Copy link
Member

mtrezza commented Jun 10, 2022 •
edited
Loading

@Meglali20 I didn't mean to fix the issue, just to fix the conflicts in this PR:
image

There have been commits to alpha since you opened this PR, so there are some conflicts between the latest code and this PR.

@Meglali20
Copy link
Contributor Author

Resolved conflicts.

mtrezza
mtrezza requested changes Jun 10, 2022
View reviewed changes
@JesperLekland
Copy link

Was there ever a fix for this? Or still just a test that showcases the bug?

@Meglali20
Copy link
Contributor Author

@JesperLekland I am not aware of any fix, I just used a workaround by creating a new class for already registered users.

@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title fix: original object not retrieved when user logs in with third party auth fix: Original object not retrieved when user logs in with third party auth Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davimacedo davimacedo

@mtrezza mtrezza

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@Meglali20 @davimacedo @mtrezza @dblythy @JesperLekland @semantic-release-bot @snyk-bot @Moumouls @marvinroger @dplewis