Skip to content

Use numpy Correlate2 for Convolve1d implementation #1358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ricardoV94 opened this issue Apr 9, 2025 · 0 comments
Open

Use numpy Correlate2 for Convolve1d implementation #1358

ricardoV94 opened this issue Apr 9, 2025 · 0 comments

Comments

@ricardoV94
Copy link
Member

ricardoV94 commented Apr 9, 2025

Description

This is what numpy.convolve uses under the hood, but we can avoid the python overhead in the C-backend: https://numpy.org/devdocs/reference/c-api/array.html#c.PyArray_Correlate2

It may make sense to actually implement everything in terms of a correlate1d and have the convolve1dbe a call oncorrelate1dwith the flipped input. Since under the hood callingnp.convolve` is doing this flip anyway.

correlate1d shows up in the gradient of convolve1d (note the [::-1] inputs)

if self.mode == "full":
valid_conv = type(self)(mode="valid")
in1_bar = valid_conv(grad, in2[::-1])
in2_bar = valid_conv(grad, in1[::-1])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant