Skip to content

Use numpy C-API for C implementations of Sort/Argsort #1359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ricardoV94 opened this issue Apr 9, 2025 · 0 comments
Open

Use numpy C-API for C implementations of Sort/Argsort #1359

ricardoV94 opened this issue Apr 9, 2025 · 0 comments

Comments

@ricardoV94
Copy link
Member

ricardoV94 commented Apr 9, 2025

Description

These are available (for argsort maybe for a single axis) in the numpy public C-API:

https://numpy.org/devdocs/reference/c-api/array.html#c.PyArray_Sort

https://numpy.org/devdocs/reference/c-api/array.html#c.PyArray_ArgSort

Using it for our own ops should be simpler than the already simple SearchSorted implementation:

if self.mode == "full":
valid_conv = type(self)(mode="valid")
in1_bar = valid_conv(grad, in2[::-1])
in2_bar = valid_conv(grad, in1[::-1])

Sort may act inplace, so we can add an inplace version of the Sort op as well (and be sure to copy when not enabled)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant