Reduce pytensor function call overhead #1351
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing all the deprecated stuff that nobody uses
I think after this there's not much more fat to trim. We could try to avoid the input/output list thing with linkers that don't need it but we still need to sort them/ recognize kwargs which is pretty much what's left.
The C part of the call takes 100ns, so the "overhead" in this case is 200-250ns.
For reference, calling
numpy.zeros(100)
takes like ~250ns, and a python identity function is ~20ns.Results of the new benchmark
Before
After
📚 Documentation preview 📚: https://pytensor--1351.org.readthedocs.build/en/1351/