[3.7] bpo-31922: Do not connect UDP sockets when broadcast is allowed (GH-423) #13162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onGH-423) *Moved from python/asyncioGH-493.* This PR fixes issue python/asyncioGH-480, as explained in [this comment](https://github.com/python/asyncio/issues/480GH-issuecomment-278703828). The `_SelectorDatagramTransport.sendto` method has to be modified ~~so `_sock.sendto` is used in all cases (because it is tricky to reliably tell if the socket is connected or not). Could that be an issue for connected sockets?~~ *EDIT* ... so `_sock.send` is used only if `_sock` is connected. It also protects `socket.getsockname` against `OSError` in `_SelectorTransport`. This might happen on Windows if the socket is not connected (e.g. for UDP broadcasting). https://bugs.python.org/issue31922 (cherry picked from commit 63deaa5) Co-authored-by: Vincent Michel <vxgmichel@gmail.com>
asvetlov
approved these changes
May 7, 2019
|
@vxgmichel: Status check is done, and it's a success ✅ . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved from python/asyncioGH-493.
This PR fixes issue python/asyncioGH-480, as explained in this comment.
The
_SelectorDatagramTransport.sendtomethod has to be modifiedsoEDIT ... so_sock.sendtois used in all cases (because it is tricky to reliably tell if the socket is connected or not). Could that be an issue for connected sockets?_sock.sendis used only if_sockis connected.It also protects
socket.getsocknameagainstOSErrorin_SelectorTransport. This might happen on Windows if the socket is not connected (e.g. for UDP broadcasting).https://bugs.python.org/issue31922
(cherry picked from commit 63deaa5)
Co-authored-by: Vincent Michel vxgmichel@gmail.com
https://bugs.python.org/issue31922